Change all URLs returned by tsd to be relative instead of absolute.#509
Closed
apech wants to merge 1 commit into
Closed
Change all URLs returned by tsd to be relative instead of absolute.#509apech wants to merge 1 commit into
apech wants to merge 1 commit into
Conversation
Member
|
LGTM, thanks for doing this. |
Member
There was a problem hiding this comment.
This doesn't work, instead of removing /q? it removes /q and leaves the ? behind. I guess we need something along the lines of uri = uri.replaceFirst("q\?", "#") or something of that effect.
Member
There was a problem hiding this comment.
Actually it's more complex than that. I'm not sure it's possible to make this one relative, which might mean that TSD might need to know the path it's rooted under. Maybe we should consider adding a setting so that TSD itself is serving all the URLs under a certain prefix.
This is necessary to root tsd under another path when it's sharing the domain with another application.
Member
|
Merged in 432d1ea. Thanks! |
johann8384
added a commit
that referenced
this pull request
Sep 1, 2016
Relative URI (continuing the work done in PR #509)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary to root tsd under another path when it's sharing the
domain with another application.