Fix race condition in UID lookup#2176
Merged
Merged
Conversation
Ensure the scanner callback waits for all the UIDs to resolve before calling scan to retrieve the next set of results. Not waiting would cause the scanner to close prematurely and return incomplete results.
manolama
approved these changes
Oct 14, 2021
manolama
left a comment
manolama
left a comment
Member
There was a problem hiding this comment.
Yup really dumb bug on my part, thanks for catching it!
Contributor
Author
|
Perfect, thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the scanner callback waits for all the UIDs to resolve before calling scan to retrieve the next set of results. If we clear lookups between each row, we only ensure the lookups have resolved for the last row in the iterator.
Not waiting can cause the scanner to close prematurely and return incomplete results.
Fixes #2175