Add full ECC Support for D-Trust Card 4.1/4.4 #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dtrust: implement ECDH key agreement
hamarituc
force-pushed
the
dtrust-ecc-derive
branch
from
1bcb07d to
adb2382
Compare
Jakuje
reviewed
Oct 18, 2024
hamarituc
force-pushed
the
dtrust-ecc-derive
branch
2 times, most recently
from
eb2f754 to
7977123
Compare
frankmorgner
requested changes
Oct 30, 2024
Member
|
Also, the linter doesn't seem to like the extra empty line: diff --git a/src/libopensc/iso7816.c b/src/libopensc/iso7816.c
index 30cebb4..e17549c 100644
--- a/src/libopensc/iso7816.c
+++ b/src/libopensc/iso7816.c
@@ -30,7 +30,6 @@
#include "iso7816.h"
#include "sm/sm-iso.h"
-
void
iso7816_fixup_transceive_length(const struct sc_card *card,
struct sc_apdu *apdu) |
The code of `fixup_transceive_length()` was duplicated multiple times in the code. Make this function public and remove duplicated code to improve maintainability.
hamarituc
force-pushed
the
dtrust-ecc-derive
branch
from
7977123 to
3f4f7cd
Compare
frankmorgner
approved these changes
Oct 30, 2024
xhanulik
approved these changes
Nov 6, 2024
frankmorgner
approved these changes
Nov 8, 2024
Member
|
@frankmorgner @Jakuje Is this good to go to 0.26.0 or should we postpone? |
Member
|
I think this is good to go for 0.26. It is changing only the dtrust driver. The changes in other files are only refactoring and should not introduce any changes in behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ECDSA signatures and ECDH key agreement for D-Trust Signatures Cards 4.1/4.4 issued by the german Bundesdruckerei.
This PR supersedes #3240. But since @frankmorgner already reviewed that PR I wouldn't like to amend it afterwards. Feel free to continue reviewing #3240 and to postpone this one or just to review this PR instead. I am unsure which way do you prefer. Sorry the noise in case you preferred just amending an already reviewed PR.
Tested on:
field_sizeextension is not present #3236Checklist