Fixes for uninitialized memory issues #3225

xhanulik · 2024-09-02T08:24:13Z

37 new use-of-uninitialized-memory bugs were found while testing fuzzing harnesses. The bugs were found in these functions:

cac_read_file()
cardos_match_card()
sc_bin_to_hex()
strcmp(), from gids_get_identifiers()
do_select()
bcmp(), from cac_list_compare_path()
insert_cert()
cardos_lifecycle_get()
gids_read_masterfile()
sc_pkcs15init_parse_info()
piv_get_challenge()
asn1_decode()
malloc(), from cac_read_file()
sc_asn1_decode_object_id()
sc_pkcs15emu_sc_hsm_decode_cvc()
gemsafe_get_cert_len()
process_fcp()
dnie_process_fci()
iso7816_process_fci()
sc_pkcs15_read_file()
strlen(), from set_string()
asn1_encode_path()
msc_extract_rsa_public_key()
sc_build_pin()
DES_set_key_unchecked(), from openssl_enc()
starcos_write_pukey()
iasecc_sdo_parse()
setcos_generate_key()
iasecc_parse_size()
iasecc_se_parse()
sc_hsm_determine_free_id()
asn1_encode_entry()
coolkey_rsa_op()
sc_asn1_read_tag()
do_init_app()
sc_pkcs15init_create_pin()
sc_asn1_clear_algorithm_id()

Reported by Matteo Marini (@Heinzeen)

Checklist

PKCS#11 module is tested
Windows minidriver is tested
macOS tokend is tested

Jakuje

lgtm also here. The only nits are the formatting suggestions, which would be good to clean up, but I can live without that :)

xhanulik · 2024-09-03T07:31:17Z

Formatting issues should be fixed.

yankov-pt · 2024-09-05T07:02:59Z

Whoa, that's a lot of affected functions!! Will there be a 0.25.2 release when this is merged?

xhanulik · 2024-09-05T07:24:51Z

Whoa, that's a lot of affected functions!! Will there be a 0.25.2 release when this is merged?

There is 0.26.0 coming in following weeks.

src/libopensc/card-oberthur.c

src/libopensc/muscle.c

src/libopensc/pkcs15-gemsafeV1.c

Thanks Matteo Marini for report GHSA-h5f7-rjr5-vx54 Signed-off-by: Jakub Jelen <[email protected]>

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_card/1,fuzz_pkcs11/6

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_card/2

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_decode/10, fuzz_pkcs15_encode/12

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/20, fuzz_pkcs15init/10

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/5,12 fuzz_pkcs15_crypt/9

In case it is not set later. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/7

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/11

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/14

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/15

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/18

In case they are not later initialize later by sc_asn1_read_tag() function. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/21

In case they are not later initialize later by sc_asn1_read_tag() function. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_crypt/12

Number of actually read bytes may differ from the stated object length. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_crypt/15

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/18

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/21

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/8

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/17, fuzz_pkcs15init/18

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/20

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/21

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/1, fuzz_pkcs15init/2

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/26

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/27,29

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/8

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_reader/3

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_reader/5

xhanulik · 2024-09-11T06:43:35Z

Thanks for reviews! Merging so we can get this moving.

New in 0.26.1; 2025-01-14 General improvements Align allocations of sc_mem_secure_alloc (OpenSC/OpenSC#3281) Fix -O3 gcc optimization failure on amd64 and ppc64el (OpenSC/OpenSC#3299) pkcs11-spy Avoid crash while spying C_GetInterface() (OpenSC/OpenSC#3275) TCOS Fix reading certificate (OpenSC/OpenSC#3296) New in 0.26.0; 2024-11-13 Security CVE-2024-45615: Usage of uninitialized values in libopensc and pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45616: Uninitialized values after incorrect check or usage of APDU response values in libopensc (OpenSC/OpenSC#3225) CVE-2024-45617: Uninitialized values after incorrect or missing checking return values of functions in libopensc (OpenSC/OpenSC#3225) CVE-2024-45618: Uninitialized values after incorrect or missing checking return values of functions in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45619: Incorrect handling length of buffers or files in libopensc (OpenSC/OpenSC#3225) CVE-2024-45620: Incorrect handling of the length of buffers or files in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-8443: Heap buffer overflow in OpenPGP driver when generating key (OpenSC/OpenSC#3219) General improvements Fix reselection of DF after error in PKCSOpenSC/OpenSC#15 layer (OpenSC/OpenSC#3067) Unify OpenSSL logging throughout code (OpenSC/OpenSC#2922) Extend the p11test to support kryoptic (OpenSC/OpenSC#3141) Fix for error in PCSC reconnection (OpenSC/OpenSC#3150) Fixed various issues reported by OSS-Fuzz and Coverity in drivers, PKCS#11 and PKCS#15 layer PKCS#15 Documentation for PKCS#15 profile files (OpenSC/OpenSC#3132) minidriver Support PinCacheAlwaysPrompt usable for PIV cards (OpenSC/OpenSC#3167) pkcs11-tool Show URI when listing token information (OpenSC/OpenSC#3125) and objects (OpenSC/OpenSC#3130) Do not limit size of objects to 5000 bytes (OpenSC/OpenSC#3174) Add support for AES CMAC (OpenSC/OpenSC#3184) Add support for AES GCM encryption (OpenSC/OpenSC#3195) Add support for RSA OAEP encryption (OpenSC/OpenSC#3175) Add support for HKDF (OpenSC/OpenSC#3193) Implement better support for wrapping and unwrapping (OpenSC/OpenSC#3198) Add support for EdDSA sign and verify (OpenSC/OpenSC#2979) pkcs15-crypt Fix PKCS#1 encoding function to correctly detect padding type (OpenSC/OpenSC#3075) piv-tool Fix RSA key generation (OpenSC/OpenSC#3158) Avoid possible state change when matching unknown card (OpenSC/OpenSC#3112) sc-hsm-tool Cleanse buffer with plaintext key share (OpenSC/OpenSC#3226) pkcs11-register Fix pkcs11-register defaults on macOS and Windows (OpenSC/OpenSC#3053) IDPrime Fix identification of IDPrime 840 cards (OpenSC/OpenSC#3146) Fix container mapping for IDPrime 940 cards (OpenSC/OpenSC#3220) Reorder ATRs for matching cards (OpenSC/OpenSC#3154) OpenPGP Fix state tracking after erasing card (OpenSC/OpenSC#3024) Belpic Disable Applet V1.8 (OpenSC/OpenSC#3109) MICARDO Deactivate driver (OpenSC/OpenSC#3152) SmartCard-HSM Fix signing with secp521r1 signature (OpenSC/OpenSC#3157) eOI Set model via sc_card_ctl function (OpenSC/OpenSC#3189) Rutoken increase the minimum PIN size to support Rutoken ECP BIO (OpenSC/OpenSC#3208) JPKI Adjust parameters for public key in PKCS#15 emulator (OpenSC/OpenSC#3182) D-Trust Add support for ECDSA signatures and ECDH key agreement for D-Trust Signatures Cards 4.1/4.4 (OpenSC/OpenSC#3240, OpenSC/OpenSC#openwrt#3248) Signed-off-by: Daniel Golle <[email protected]>

New in 0.26.1; 2025-01-14 General improvements Align allocations of sc_mem_secure_alloc (OpenSC/OpenSC#3281) Fix -O3 gcc optimization failure on amd64 and ppc64el (OpenSC/OpenSC#3299) pkcs11-spy Avoid crash while spying C_GetInterface() (OpenSC/OpenSC#3275) TCOS Fix reading certificate (OpenSC/OpenSC#3296) New in 0.26.0; 2024-11-13 Security CVE-2024-45615: Usage of uninitialized values in libopensc and pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45616: Uninitialized values after incorrect check or usage of APDU response values in libopensc (OpenSC/OpenSC#3225) CVE-2024-45617: Uninitialized values after incorrect or missing checking return values of functions in libopensc (OpenSC/OpenSC#3225) CVE-2024-45618: Uninitialized values after incorrect or missing checking return values of functions in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45619: Incorrect handling length of buffers or files in libopensc (OpenSC/OpenSC#3225) CVE-2024-45620: Incorrect handling of the length of buffers or files in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-8443: Heap buffer overflow in OpenPGP driver when generating key (OpenSC/OpenSC#3219) General improvements Fix reselection of DF after error in PKCSOpenSC/OpenSC#15 layer (OpenSC/OpenSC#3067) Unify OpenSSL logging throughout code (OpenSC/OpenSC#2922) Extend the p11test to support kryoptic (OpenSC/OpenSC#3141) Fix for error in PCSC reconnection (OpenSC/OpenSC#3150) Fixed various issues reported by OSS-Fuzz and Coverity in drivers, PKCS#11 and PKCS#15 layer PKCS#15 Documentation for PKCS#15 profile files (OpenSC/OpenSC#3132) minidriver Support PinCacheAlwaysPrompt usable for PIV cards (OpenSC/OpenSC#3167) pkcs11-tool Show URI when listing token information (OpenSC/OpenSC#3125) and objects (OpenSC/OpenSC#3130) Do not limit size of objects to 5000 bytes (OpenSC/OpenSC#3174) Add support for AES CMAC (OpenSC/OpenSC#3184) Add support for AES GCM encryption (OpenSC/OpenSC#3195) Add support for RSA OAEP encryption (OpenSC/OpenSC#3175) Add support for HKDF (OpenSC/OpenSC#3193) Implement better support for wrapping and unwrapping (OpenSC/OpenSC#3198) Add support for EdDSA sign and verify (OpenSC/OpenSC#2979) pkcs15-crypt Fix PKCS#1 encoding function to correctly detect padding type (OpenSC/OpenSC#3075) piv-tool Fix RSA key generation (OpenSC/OpenSC#3158) Avoid possible state change when matching unknown card (OpenSC/OpenSC#3112) sc-hsm-tool Cleanse buffer with plaintext key share (OpenSC/OpenSC#3226) pkcs11-register Fix pkcs11-register defaults on macOS and Windows (OpenSC/OpenSC#3053) IDPrime Fix identification of IDPrime 840 cards (OpenSC/OpenSC#3146) Fix container mapping for IDPrime 940 cards (OpenSC/OpenSC#3220) Reorder ATRs for matching cards (OpenSC/OpenSC#3154) OpenPGP Fix state tracking after erasing card (OpenSC/OpenSC#3024) Belpic Disable Applet V1.8 (OpenSC/OpenSC#3109) MICARDO Deactivate driver (OpenSC/OpenSC#3152) SmartCard-HSM Fix signing with secp521r1 signature (OpenSC/OpenSC#3157) eOI Set model via sc_card_ctl function (OpenSC/OpenSC#3189) Rutoken increase the minimum PIN size to support Rutoken ECP BIO (OpenSC/OpenSC#3208) JPKI Adjust parameters for public key in PKCS#15 emulator (OpenSC/OpenSC#3182) D-Trust Add support for ECDSA signatures and ECDH key agreement for D-Trust Signatures Cards 4.1/4.4 (OpenSC/OpenSC#3240, OpenSC/OpenSC##3248) Signed-off-by: Daniel Golle <[email protected]>

Jakuje approved these changes Sep 2, 2024

View reviewed changes

xhanulik force-pushed the uninitialized-memory branch 2 times, most recently from b841531 to 170ffde Compare September 3, 2024 07:28

Jakuje approved these changes Sep 3, 2024

View reviewed changes

frankmorgner requested changes Sep 9, 2024

View reviewed changes

src/libopensc/card-oberthur.c Outdated Show resolved Hide resolved

src/libopensc/muscle.c Outdated Show resolved Hide resolved

src/libopensc/muscle.c Show resolved Hide resolved

src/libopensc/pkcs15-gemsafeV1.c Show resolved Hide resolved

Jakuje and others added 7 commits September 10, 2024 09:51

gids: Avoid using uninitialized memory

f25c61d

Thanks Matteo Marini for report GHSA-h5f7-rjr5-vx54 Signed-off-by: Jakub Jelen <[email protected]>

pkcs15init: Avoid using uninitialized memory

a905ad4

Thanks Matteo Marini for report GHSA-h5f7-rjr5-vx54 Signed-off-by: Jakub Jelen <[email protected]>

pkcs15init: Remove tab indentation

4ca050b

cac: Correctly calculate certificate length based on the resplen

5580be5

Thanks Matteo Marini for report GHSA-h5f7-rjr5-vx54 Signed-off-by: Jakub Jelen <[email protected]>

cac: Fix uninitialized values

9da37a8

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_card/1,fuzz_pkcs11/6

cardos: Fix uninitialized values

39a55ef

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_card/2

card-dnie: Check APDU response length and ASN1 lengths

e66619f

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_decode/10, fuzz_pkcs15_encode/12

xhanulik force-pushed the uninitialized-memory branch from 170ffde to 623c422 Compare September 10, 2024 07:52

xhanulik added 14 commits September 10, 2024 09:54

muscle: Report invalid SW when reading object

737931e

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/20, fuzz_pkcs15init/10

card-mcrd: Check length of response buffer in select

e7f6a24

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/5,12 fuzz_pkcs15_crypt/9

pkcs15-cert.c: Initialize OID length

d18a07e

In case it is not set later. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/7

card-gids: Use actual length of reponse buffer

c65e6f0

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/11

cac: Check return value when selecting AID

3b242c5

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/14

pkcs15-tcos: Check number of read bytes for cert

19d5557

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/15

cardos: Return error when response length is 0

74d42f3

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/18

card-piv: Initialize variables for tag and CLA

2e6333f

In case they are not later initialize later by sc_asn1_read_tag() function. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/21

pkcs15-sc-hsm: Initialize variables for tag and CLA

95815e4

In case they are not later initialize later by sc_asn1_read_tag() function. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_crypt/12

pkcs15-gemsafeV1: Check length of buffer for object

16e0af0

Number of actually read bytes may differ from the stated object length. Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_crypt/15

card-jpki: Check number of read bytes

5aad776

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/18

pkcs15-tcos: Check return value of serial num conversion

535e9d6

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/21

pkcs15-tcos: Check certificate length before accessing

230a783

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_encode/8

pkcs15-lib: Report transport key error

afb1bba

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/17, fuzz_pkcs15init/18

xhanulik added 9 commits September 10, 2024 09:54

pkcs15-starcos: Check length of file to be non-zero

60f08c6

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/20

iasecc-sdo: Check length of data before dereferencing

513d3fd

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/21

card-oberthur: Check length of serial number

b1cdaf4

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs11/1, fuzz_pkcs15init/2

pkcs15-setcos: Check length of generated key

67064f4

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/26

iasecc-sdo: Check length of data when parsing

c911e5f

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/27,29

pkcs15-sc-hsm: Properly check length of file list

755448b

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15init/8

card-coolkey: Check length of buffer before conversion

9c8c25a

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_reader/3

card-entersafe: Check length of serial number

b6754eb

Thanks Matteo Marini for report GHSA-p3mx-7472-h3j8 fuzz_pkcs15_reader/5

card-cardos: Check length of APDU response

ab47604

xhanulik force-pushed the uninitialized-memory branch from 623c422 to ab47604 Compare September 10, 2024 07:55

frankmorgner approved these changes Sep 10, 2024

View reviewed changes

xhanulik merged commit 265b283 into OpenSC:master Sep 11, 2024

xhanulik mentioned this pull request Sep 11, 2024

Towards new release 0.26.0 #3223

Closed

xhanulik deleted the uninitialized-memory branch October 18, 2024 13:41

michaeladler mentioned this pull request Nov 13, 2024

opensc: 0.25.1 -> 0.26.0 NixOS/nixpkgs#345666

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes for uninitialized memory issues #3225

Fixes for uninitialized memory issues #3225

Uh oh!

xhanulik commented Sep 2, 2024 •

edited

Loading

Uh oh!

Jakuje left a comment

Uh oh!

xhanulik commented Sep 3, 2024

Uh oh!

yankov-pt commented Sep 5, 2024

Uh oh!

xhanulik commented Sep 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xhanulik commented Sep 11, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fixes for uninitialized memory issues #3225

Fixes for uninitialized memory issues #3225

Uh oh!

Conversation

xhanulik commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Jakuje left a comment

Choose a reason for hiding this comment

Uh oh!

xhanulik commented Sep 3, 2024

Uh oh!

yankov-pt commented Sep 5, 2024

Uh oh!

xhanulik commented Sep 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xhanulik commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xhanulik commented Sep 2, 2024 •

edited

Loading

xhanulik commented Sep 11, 2024 •

edited

Loading