Include uri in pkcs11-tool -L option #3125

sarroutbi · 2024-04-19T14:19:33Z

Tests performed with Yubico Yubikey 5 NFC:

$ opensc-tool -n
Using reader with a card: Yubico YubiKey OTP+CCID 00 00
Personal Identity Verification Card

sarroutbi · 2024-04-19T15:23:43Z

I have also cross-checked the output with other tools, and it seems reasonable:

$ systemd-cryptenroll --pkcs11-token=list; ./src/tools/pkcs11-tool -L | grep uri | awk -F ': ' '{print $NF}' 
| tr -d ' '
URI                                                                                        LABEL  MANUFACTURER MODEL           
pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=abcdef1234567890;token=clevis clevis piv_II       PKCS#15 emulated
pkcs11:model=PKCS%2315%20emulated;manufacturer=piv_II;serial=abcdef1234567890;token=clevis

ccamposr

lgtm

src/tools/pkcs11-tool.c

Fixes: OpenSC#3123 Signed-off-by: Sergio Arroutbi <[email protected]>

Jakuje

I think this is good to go.

One possible area to extend this could be printing the URI for the objects too (which could reuse most of the current code) and some test coverage to see the URIs printed make sense. Should be quite easy to start from for example tests/test-pkcs11-tool-import.sh and grep for the important uri parts.

src/tools/pkcs11-tool.c

Co-authored-by: Jakub Jelen <[email protected]>

sarroutbi · 2024-04-25T11:43:40Z

I think this is good to go.

One possible area to extend this could be printing the URI for the objects too (which could reuse most of the current code) and some test coverage to see the URIs printed make sense. Should be quite easy to start from for example tests/test-pkcs11-tool-import.sh and grep for the important uri parts.

Sure. I will open an issue for it and I will create a PR for that.

Thanks for your help, @Jakuje

Jakuje

Thank you! Lets wait if others will have some comments and if not, I will merge it next week.

Jakuje · 2024-04-30T07:47:36Z

Thank you for your contribution!

sarroutbi · 2024-04-30T10:11:18Z

I think this is good to go.

One possible area to extend this could be printing the URI for the objects too (which could reuse most of the current code) and some test coverage to see the URIs printed make sense. Should be quite easy to start from for example tests/test-pkcs11-tool-import.sh and grep for the important uri parts.

Hello Jakub. I opened #3129 for this extension.

New in 0.26.1; 2025-01-14 General improvements Align allocations of sc_mem_secure_alloc (OpenSC/OpenSC#3281) Fix -O3 gcc optimization failure on amd64 and ppc64el (OpenSC/OpenSC#3299) pkcs11-spy Avoid crash while spying C_GetInterface() (OpenSC/OpenSC#3275) TCOS Fix reading certificate (OpenSC/OpenSC#3296) New in 0.26.0; 2024-11-13 Security CVE-2024-45615: Usage of uninitialized values in libopensc and pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45616: Uninitialized values after incorrect check or usage of APDU response values in libopensc (OpenSC/OpenSC#3225) CVE-2024-45617: Uninitialized values after incorrect or missing checking return values of functions in libopensc (OpenSC/OpenSC#3225) CVE-2024-45618: Uninitialized values after incorrect or missing checking return values of functions in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45619: Incorrect handling length of buffers or files in libopensc (OpenSC/OpenSC#3225) CVE-2024-45620: Incorrect handling of the length of buffers or files in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-8443: Heap buffer overflow in OpenPGP driver when generating key (OpenSC/OpenSC#3219) General improvements Fix reselection of DF after error in PKCSOpenSC/OpenSC#15 layer (OpenSC/OpenSC#3067) Unify OpenSSL logging throughout code (OpenSC/OpenSC#2922) Extend the p11test to support kryoptic (OpenSC/OpenSC#3141) Fix for error in PCSC reconnection (OpenSC/OpenSC#3150) Fixed various issues reported by OSS-Fuzz and Coverity in drivers, PKCS#11 and PKCS#15 layer PKCS#15 Documentation for PKCS#15 profile files (OpenSC/OpenSC#3132) minidriver Support PinCacheAlwaysPrompt usable for PIV cards (OpenSC/OpenSC#3167) pkcs11-tool Show URI when listing token information (OpenSC/OpenSC#3125) and objects (OpenSC/OpenSC#3130) Do not limit size of objects to 5000 bytes (OpenSC/OpenSC#3174) Add support for AES CMAC (OpenSC/OpenSC#3184) Add support for AES GCM encryption (OpenSC/OpenSC#3195) Add support for RSA OAEP encryption (OpenSC/OpenSC#3175) Add support for HKDF (OpenSC/OpenSC#3193) Implement better support for wrapping and unwrapping (OpenSC/OpenSC#3198) Add support for EdDSA sign and verify (OpenSC/OpenSC#2979) pkcs15-crypt Fix PKCS#1 encoding function to correctly detect padding type (OpenSC/OpenSC#3075) piv-tool Fix RSA key generation (OpenSC/OpenSC#3158) Avoid possible state change when matching unknown card (OpenSC/OpenSC#3112) sc-hsm-tool Cleanse buffer with plaintext key share (OpenSC/OpenSC#3226) pkcs11-register Fix pkcs11-register defaults on macOS and Windows (OpenSC/OpenSC#3053) IDPrime Fix identification of IDPrime 840 cards (OpenSC/OpenSC#3146) Fix container mapping for IDPrime 940 cards (OpenSC/OpenSC#3220) Reorder ATRs for matching cards (OpenSC/OpenSC#3154) OpenPGP Fix state tracking after erasing card (OpenSC/OpenSC#3024) Belpic Disable Applet V1.8 (OpenSC/OpenSC#3109) MICARDO Deactivate driver (OpenSC/OpenSC#3152) SmartCard-HSM Fix signing with secp521r1 signature (OpenSC/OpenSC#3157) eOI Set model via sc_card_ctl function (OpenSC/OpenSC#3189) Rutoken increase the minimum PIN size to support Rutoken ECP BIO (OpenSC/OpenSC#3208) JPKI Adjust parameters for public key in PKCS#15 emulator (OpenSC/OpenSC#3182) D-Trust Add support for ECDSA signatures and ECDH key agreement for D-Trust Signatures Cards 4.1/4.4 (OpenSC/OpenSC#3240, OpenSC/OpenSC#openwrt#3248) Signed-off-by: Daniel Golle <[email protected]>

New in 0.26.1; 2025-01-14 General improvements Align allocations of sc_mem_secure_alloc (OpenSC/OpenSC#3281) Fix -O3 gcc optimization failure on amd64 and ppc64el (OpenSC/OpenSC#3299) pkcs11-spy Avoid crash while spying C_GetInterface() (OpenSC/OpenSC#3275) TCOS Fix reading certificate (OpenSC/OpenSC#3296) New in 0.26.0; 2024-11-13 Security CVE-2024-45615: Usage of uninitialized values in libopensc and pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45616: Uninitialized values after incorrect check or usage of APDU response values in libopensc (OpenSC/OpenSC#3225) CVE-2024-45617: Uninitialized values after incorrect or missing checking return values of functions in libopensc (OpenSC/OpenSC#3225) CVE-2024-45618: Uninitialized values after incorrect or missing checking return values of functions in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-45619: Incorrect handling length of buffers or files in libopensc (OpenSC/OpenSC#3225) CVE-2024-45620: Incorrect handling of the length of buffers or files in pkcs15init (OpenSC/OpenSC#3225) CVE-2024-8443: Heap buffer overflow in OpenPGP driver when generating key (OpenSC/OpenSC#3219) General improvements Fix reselection of DF after error in PKCSOpenSC/OpenSC#15 layer (OpenSC/OpenSC#3067) Unify OpenSSL logging throughout code (OpenSC/OpenSC#2922) Extend the p11test to support kryoptic (OpenSC/OpenSC#3141) Fix for error in PCSC reconnection (OpenSC/OpenSC#3150) Fixed various issues reported by OSS-Fuzz and Coverity in drivers, PKCS#11 and PKCS#15 layer PKCS#15 Documentation for PKCS#15 profile files (OpenSC/OpenSC#3132) minidriver Support PinCacheAlwaysPrompt usable for PIV cards (OpenSC/OpenSC#3167) pkcs11-tool Show URI when listing token information (OpenSC/OpenSC#3125) and objects (OpenSC/OpenSC#3130) Do not limit size of objects to 5000 bytes (OpenSC/OpenSC#3174) Add support for AES CMAC (OpenSC/OpenSC#3184) Add support for AES GCM encryption (OpenSC/OpenSC#3195) Add support for RSA OAEP encryption (OpenSC/OpenSC#3175) Add support for HKDF (OpenSC/OpenSC#3193) Implement better support for wrapping and unwrapping (OpenSC/OpenSC#3198) Add support for EdDSA sign and verify (OpenSC/OpenSC#2979) pkcs15-crypt Fix PKCS#1 encoding function to correctly detect padding type (OpenSC/OpenSC#3075) piv-tool Fix RSA key generation (OpenSC/OpenSC#3158) Avoid possible state change when matching unknown card (OpenSC/OpenSC#3112) sc-hsm-tool Cleanse buffer with plaintext key share (OpenSC/OpenSC#3226) pkcs11-register Fix pkcs11-register defaults on macOS and Windows (OpenSC/OpenSC#3053) IDPrime Fix identification of IDPrime 840 cards (OpenSC/OpenSC#3146) Fix container mapping for IDPrime 940 cards (OpenSC/OpenSC#3220) Reorder ATRs for matching cards (OpenSC/OpenSC#3154) OpenPGP Fix state tracking after erasing card (OpenSC/OpenSC#3024) Belpic Disable Applet V1.8 (OpenSC/OpenSC#3109) MICARDO Deactivate driver (OpenSC/OpenSC#3152) SmartCard-HSM Fix signing with secp521r1 signature (OpenSC/OpenSC#3157) eOI Set model via sc_card_ctl function (OpenSC/OpenSC#3189) Rutoken increase the minimum PIN size to support Rutoken ECP BIO (OpenSC/OpenSC#3208) JPKI Adjust parameters for public key in PKCS#15 emulator (OpenSC/OpenSC#3182) D-Trust Add support for ECDSA signatures and ECDH key agreement for D-Trust Signatures Cards 4.1/4.4 (OpenSC/OpenSC#3240, OpenSC/OpenSC##3248) Signed-off-by: Daniel Golle <[email protected]>

sarroutbi force-pushed the 202404191601-print-uri-p11-tool branch 7 times, most recently from 3558894 to c27e972 Compare April 19, 2024 15:05

sarroutbi marked this pull request as ready for review April 19, 2024 15:35

ccamposr approved these changes Apr 19, 2024

View reviewed changes

Jakuje reviewed Apr 24, 2024

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

sarroutbi force-pushed the 202404191601-print-uri-p11-tool branch 3 times, most recently from 5c0c15b to b645d41 Compare April 25, 2024 10:35

Include uri in pkcs11-tool -L option

700b6e7

Fixes: OpenSC#3123 Signed-off-by: Sergio Arroutbi <[email protected]>

sarroutbi force-pushed the 202404191601-print-uri-p11-tool branch from b645d41 to 700b6e7 Compare April 25, 2024 10:39

Jakuje approved these changes Apr 25, 2024

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

Update src/tools/pkcs11-tool.c

d9119d0

Co-authored-by: Jakub Jelen <[email protected]>

Jakuje approved these changes Apr 26, 2024

View reviewed changes

Jakuje merged commit 1fb5655 into OpenSC:master Apr 30, 2024

sarroutbi deleted the 202404191601-print-uri-p11-tool branch April 30, 2024 07:59

sarroutbi mentioned this pull request Apr 30, 2024

pkcs11-tool: extend for printing the PKCS#11 URI for the objects #3129

Closed

xhanulik mentioned this pull request Aug 29, 2024

Towards new release 0.26.0 #3223

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Include uri in pkcs11-tool -L option #3125

Include uri in pkcs11-tool -L option #3125

Uh oh!

sarroutbi commented Apr 19, 2024 •

edited

Loading

Uh oh!

sarroutbi commented Apr 19, 2024 •

edited

Loading

Uh oh!

ccamposr left a comment

Uh oh!

Uh oh!

Uh oh!

Jakuje left a comment

Uh oh!

Uh oh!

sarroutbi commented Apr 25, 2024

Uh oh!

Jakuje left a comment

Uh oh!

Jakuje commented Apr 30, 2024

Uh oh!

sarroutbi commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Include uri in pkcs11-tool -L option #3125

Include uri in pkcs11-tool -L option #3125

Uh oh!

Conversation

sarroutbi commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sarroutbi commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ccamposr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jakuje left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sarroutbi commented Apr 25, 2024

Uh oh!

Jakuje left a comment

Choose a reason for hiding this comment

Uh oh!

Jakuje commented Apr 30, 2024

Uh oh!

sarroutbi commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sarroutbi commented Apr 19, 2024 •

edited

Loading

sarroutbi commented Apr 19, 2024 •

edited

Loading