rutoken_ecp: add support for RSA 4096 key algorithm #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that not all Rutoken ECP tokens support rsa 4096 keys, but it is impossible to distinguish them from those that do. The rsa_prop[] data looks like an exponent encoded in ASN.1, but changing it does not produce key with specified exponent. Without this data rutoken generates malformed rsa:4096 key. Signed-off-by: Egor Ignatov <[email protected]>
Jakuje
approved these changes
Feb 1, 2024
frankmorgner
approved these changes
Feb 1, 2024
Contributor
Author
|
Hi, This is my first contribution to OpenSC. |
Member
|
Thank you! No more actions needed. We just left it for other members to review. Given there are no other concerns, I am merging this and it will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that not all Rutoken ECP tokens support rsa 4096 keys, but it is impossible to distinguish them from those that do.
The rsa_prop[] data looks like an exponent encoded in ASN.1, but changing it does not produce key with specified exponent. Without this data rutoken generates malformed rsa:4096 key.
Checklist