Various improvements for the p11test #2991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmorgner
approved these changes
Jan 23, 2024
Member
Author
|
Rebased on top of master (squashing some of the style warnings) and added also a p11test as part of the CI run together with the PKCS11SPY to catch issues such as #2988 earlier. |
Jakuje
force-pushed
the
p11test-wip
branch
2 times, most recently
from
6cc1009 to
f15be8a
Compare
frankmorgner
approved these changes
Jan 25, 2024
Member
Author
|
Hopefully last slight changes of the pipeline to pass. |
Member
Author
|
Now, we should see only failure in the valgrind as we are getting uninitialized memory from softhsm. Not sure what to do about that, but I think that can be handled later. |
xhanulik
reviewed
Jan 30, 2024
Jakuje
force-pushed
the
p11test-wip
branch
2 times, most recently
from
63d8424 to
2c3beb9
Compare
Member
Author
|
I think this should be final now. |
… different version
…ith distinct label
we skip the mechanism and interface test when comparing the output because: * softhsm is using uninitialized memory when providing mechanism list causing random flags to appear or disappear randomly * the softhsm does not support interfaces, while pkcs11 spy does
frankmorgner
approved these changes
Jan 30, 2024
xhanulik
approved these changes
Jan 30, 2024
Member
Author
|
Merging. Thanks for reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues in the p11test found mostly while testing over last months.
Checklist