-
Notifications
You must be signed in to change notification settings - Fork 803
Support uncompressed certificates on IDPrime 940 #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb58491 to
7e2a358
Compare
Jakuje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with all bunch cards I have lying around and all looks good! Thank you for your contribution!
|
Excellent! Now to start messing with the IDEMIA 9 cards... |
frankmorgner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let us know when you think this PR is finalized
|
From my side, I think we are good, but I would like @xhanulik to check the modified code for the certificate compression. |
|
I'm also happy with it, provided nothing else comes up. |
xhanulik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Thank you! |
|
@Jakuje Unfortunately, I no longer have access to the cards I used while implementing support. I've changed workplaces and of course had to turn in my smartcard :( I could try to get one of my previous colleagues in the loop on this issue to see if they're up for it. |
Thank you! If you have someone that would be willing to provide this information, it would be helpful. Lets continue discussion in #3154 -- I was not sure if tagging you there would work to send out the notification. |
This PR intends to fix handling of uncompressed certificates in Gemalto IDPrime cards. I'm currently testing this on a 940 (applet version 4), but other card variants may be affected.
Specifically, the PR fixes a bug with the data caching when reading binary data from the card, as well as ensuring that the on-card file sizes are known regardless of the compression state of the file.
Fixes #2956.
Checklist