card-idprime.c : add support for Gemalto IDPrime 940C #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define Gemalto IDPrime 940C as SC_CARD_TYPE_IDPRIME_940
Jakuje
approved these changes
Nov 23, 2023
Member
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
looks good! Thank you for your contribution and confirmation it works for you!
Comment on lines
61
to
+67
| "ff:ff:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:00:00:ff:ff:ff", | ||
| "Gemalto IDPrime 940", | ||
| SC_CARD_TYPE_IDPRIME_940, 0, NULL }, | ||
| { "3b:7f:96:00:00:80:31:80:65:b0:85:05:00:39:12:0f:fe:82:90:00", | ||
| "ff:ff:00:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:00:00:ff:ff:ff", | ||
| "Gemalto IDPrime 940C", | ||
| SC_CARD_TYPE_IDPRIME_940, 0, NULL }, |
Member
There was a problem hiding this comment.
Passing the ATR into the ATR parser, the block with difference is a block pre-issuing data, but it looks like the rest is the same for also the IDPrime 840 so I am ok with the change.
frankmorgner
approved these changes
Nov 24, 2023
Member
|
This one is trivial enough so we can get it into the 0.24.0 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define Gemalto IDPrime 940C as SC_CARD_TYPE_IDPRIME_940
We have recently encountered an issue with OpenSC when using the Gemalto IDPrime 940C card, which is a newer variant of the Gemalto IDPrime 940. After investigating the problem, we have made modifications to OpenSC to add support for Gemalto IDPrime 940C.
The ATR of our Gemalto IDPrime 940C card is 3b:7f:96:00:00:80:31:80:65:b0:85:05:00:39:12:0f:fe:82:90:00.
Without our patch, attempting to use Gemalto IDPrime 940C (via
pkcs11-tool --login --test) resulted in the following error:With the applied patch, we have successfully authenticated using the PIN code and signed documents without encountering any issues.
We acknowledge that we may not be deeply familiar with the OpenSC codebase and the subtleties regarding ATRs. However, with the provided patch, we have successfully resolved the issue and verified that Gemalto IDPrime 940C works as expected.
Thank you for your time.