-
Notifications
You must be signed in to change notification settings - Fork 803
pkcs15_gen_keypair: propagate SENSITIVE/EXTRACTABLE flag from PKCS11 to PKCS15 #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/tools/pkcs11-tool.1.xml
Outdated
| tools: | ||
| <programlisting>openssl x509 -inform DER -in cert.der -outform PEM > cert.pem</programlisting> | ||
|
|
||
| Generate new key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be more explicit here like "generate new RSA Key pair" to be obvious both of the keys are generated and to avoid confusion with generating symmetric key. Same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll change it..
…to PKCS15 When generating the private key, we transfer the request for the CKA_SENSITIVE and CKA_EXTRACTABLE key attributes up to the pkcs#15 layer. When reading attributes from the PKCS#15 layer, set the CKA_EXTRACTABLE attribute for the pkcs#11 layer according to the SC_PKCS15_PRKEY_ACCESS_EXTRACTABLE attribute. modified: src/pkcs11/framework-pkcs15.c
modified: doc/tools/pkcs11-tool.1.xml
|
I prepared a test branch, but I have some strange problem with compilation on CI.. make[4]: *** No rule to make target 'org.opensc-project.mac.pkcs11-register.plist.in', needed by 'org.opensc-project.mac.pkcs11-register.plist'. Stop. https://github.com/popovec/OpenSC/actions/runs/6886758679 |
|
Running the logs through diff shows that all dependencies versions are the same. But going through the logs shows the following issue which goes undetected during the in short, given that the branch name is used as part of the version, too long file paths are created, which are not handled by the |
|
Thanks for the hint. I did not expect such a restriction at all. |
db5d4fa to
c8f405f
Compare
Me neither. Learning something new every day :) |
|
There are ustar and pax extensions for tar to allow longer filenames. Default is 100 chars |
When generating the private key, we transfer the request for the CKA_SENSITIVE and CKA_EXTRACTABLE key attributes up to the pkcs#15 layer.
When reading attributes from the PKCS#15 layer, set the CKA_EXTRACTABLE attribute for the pkcs#11 layer according to the SC_PKCS15_PRKEY_ACCESS_EXTRACTABLE attribute.