minidriver: Fix wrong hash selection in CardSignData if pszAlgId is NULL #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to CardSignData docs, if pszAlgId is NULL, OID should not be added to signature, but minidriver erroneously selects SC_ALGORITHM_RSA_HASH_MD5_SHA1. See: https://learn.microsoft.com/en-us/windows/win32/api/bcrypt/ns-bcrypt-bcrypt_pkcs1_padding_info
frankmorgner
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
CardSignDatadocs, ifpszAlgIdisNULL, OID should not be added to signature, but minidriver erroneously selectsSC_ALGORITHM_RSA_HASH_MD5_SHA1.See: BCRYPT_PKCS1_PADDING_INFO structure description
Checklist