Skip to content

Conversation

@metsma
Copy link
Contributor

@metsma metsma commented Nov 7, 2023

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

Signed-off-by: Raul Metsma [email protected]

@frankmorgner
Copy link
Member

I think it would be good to schedule this when after the upcoming version was released.

I agree with the suggested change, although I'd like to note that extended support for 1.1.1 is still available

@metsma
Copy link
Contributor Author

metsma commented Nov 8, 2023

I think it would be good to schedule this when after the upcoming version was released.

I agree

I agree with the suggested change, although I'd like to note that extended support for 1.1.1 is still available

Thats why I did not touch configure script. It is still possible build with 1.1.1. But default build should produce "suppored" binary

@frankmorgner
Copy link
Member

Agreed. Our AppVeyor configuration should be changed to use the pre installed 3.0 version as well then.

@metsma
Copy link
Contributor Author

metsma commented Nov 8, 2023

Huh haven't used AppVeyor recently. Is there reason that OpenSC does not use GitHub Actions windows environments?

@frankmorgner
Copy link
Member

  1. We're using AppVeyor for historical reasons
  2. My long term plan is to integrate Signpath, which currently doesn't support GHA

@Jakuje
Copy link
Member

Jakuje commented Dec 19, 2023

@metsma can you please rebase so we can re-triger the CI and make sure everything works before merging? Release is out so I would like to give this some more testing.

Signed-off-by: Raul Metsma <[email protected]>
@metsma
Copy link
Contributor Author

metsma commented Dec 19, 2023

Done

@Jakuje
Copy link
Member

Jakuje commented Dec 19, 2023

Looking at the https://www.openssl.org/source/ I am wondering if we should keep the 3.0 or jump to 3.2 directly, which is latest stable (but has shorter support). But that can be done in separate PR later if we would like to go that direction. I think this is good to merge now.

@frankmorgner
Copy link
Member

I think it is better to stick to the LTS version.

@frankmorgner frankmorgner merged commit 2931688 into OpenSC:master Dec 20, 2023
@metsma metsma deleted the openssl branch December 20, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants