pkcs15-framework.c NSS tests profile for CKA_TOKEN #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Jakuje
approved these changes
Nov 7, 2023
Member
|
Discussed briefly with Bob about the NSS implementation and really the consensus should be that this is the right solution. If we do not provide the CKA_TOKEN=CK_TRUE, the specification defaults to FALSE, which means that the object is session-only, which really does not make much sense. Would be glad for comments on #2928 which is related to the fix already verified in #2920. |
frankmorgner
approved these changes
Nov 14, 2023
Date: Thu Nov 2 09:00:17 2023 -0500 On branch pkcs11-profile-fix Changes to be committed: modified: framework-pkcs15.c
dengert
force-pushed
the
pkcs11-profile-fix
branch
from
45df042 to
3422223
Compare
Member
|
Thank you! Lets get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2920 Needs test using NSS
NSS use template with CKO_CLASS = CKO_PROFILE and CKA_TOKEN = CK_TRUE to find profiles.
pkcs15_framwork.c now responds withy CKA_TOKEN = CK_TRUE.
Previously would return CKR_ATTRIBUTE_TYPE_INVALID
Date: Thu Nov 2 09:00:17 2023 -0500
On branch pkcs11-profile-fix
Changes to be committed:
modified: framework-pkcs15.c
Checklist