pkcs11-tool.c - test CLASS for CKO_PRIVATE_KEY #2913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests for "CKO_PRIVATE_KEY" Use "getCLASS" not "getKEY_TYPE" On branch object-class Changes to be committed: modified: src/tools/pkcs11-tool.c
Jakuje
approved these changes
Oct 24, 2023
Member
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
noticed the same couple of hours back. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests for "CKO_PRIVATE_KEY" Use "getCLASS" not "getKEY_TYPE"
which caused login(session,CKU_CONTEXT_SPECIFIC); to never be called.
On branch object-class
Changes to be committed:
modified: src/tools/pkcs11-tool.c
Checklist