pkcs11: use secure memory for puk if configured for `init_pin_in_so_s… #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
approved these changes
Oct 31, 2023
Member
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
looks good. Do you want this for the 0.24.0? I do not see a reason why it should not be there, but rather checking anyway.
Member
Author
|
as you prefer. I think it can be included in 0.24.0 |
Member
|
I think it would be better merged earlier to get it tested rather than later. It should be not cause any issues though. Merging then. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ession`
Checklist