opensc-notify: Fix wrong popup menu popup position #2901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frankmorgner
left a comment
frankmorgner
left a comment
There was a problem hiding this comment.
Looks good.
If we rely on EnumDisplaySettings to be successful, then info.rcMonitor.right - info.rcMonitor.left should not be 0. Do you think it makes sense to test for this anyway in order to prevent a possible devision by zero?
If monitor resolution scaling is used, opensc-notify.exe popup menu pops up at the wrong position.
Contributor
Author
|
I also share the opinion the division by zero shouldn't occur, but I guess one more check doesn't hurt... |
Member
|
Thank you for the contribution and reviews! I do not have a way to test it, but I think it is good to go for 0.24.0 unless there would be some concerns against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If monitor resolution scaling is used, opensc-notify.exe popup menu pops up at the wrong position.