enable use_file_cache for MyEID card #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankmorgner
requested changes
Jun 9, 2023
Member
Author
|
Ok "size_t" is perfectly sufficient. |
…ache. The card's file cache needs a timestamp so that we know when the cache does not match the card's content. The solution used so far is based on information from EF.Tokeninfo, where the time of the last modification of the card is recorded. However, EF.Tokeninfo does not provide sufficient granularity of the timestamp and is not updated atomically for changes on the card. Some of the cards provide an internal "change counter", which is incremented after each change of the card's content. If such information is available, it is used as a timestamp for the name of the card's cached file. modified: src/libopensc/cardctl.h modified: src/libopensc/pkcs15-cache.c
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements new card_ctl (SC_CARDCTL_GET_CHANGE_COUNTER) which makes it possible to identify every change on the card. This information allows us to safely use the file cache even if the contents of the card is changed on another computer. In this PR, this operation is implemented for the MyEID driver and the file cache for the MyEID card is turned on by default.
Checklist