Skip to content

pkcs11-tool: add cipher test mode #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankmorgner merged 5 commits into from
Aug 15, 2023
Merged

pkcs11-tool: add cipher test mode #2780

frankmorgner merged 5 commits into from
Aug 15, 2023

Conversation

@dlegaultbbry
Copy link
Contributor

@dlegaultbbry dlegaultbbry commented May 11, 2023

Add support for non-AEAD ciphers to the tool test
mode to assert that Encrypt/Decrypt APIs work correctly using established test vectors.

Tested using a softhsm supporting the algorithms on a QNX target

# pkcs11-tool --module=/system/lib/dll/pkcs11-module.so --test
Using slot 0 with a present token (0x0)
C_SeedRandom() and C_GenerateRandom():
  seems to be OK
Digests:
  all 4 digest functions seem to work
  SHA256: OK
Ciphers:
  AES-ECB: OK
  AES-CBC: OK
Signatures: not implemented
Verify: not implemented
Decryption (currently only for RSA)
No errors

@frankmorgner
Copy link
Member

frankmorgner commented May 12, 2023

I know we have some problems with the CI pipeline, but please look at the individual messages, e.g.
https://github.com/OpenSC/OpenSC/actions/runs/4947970899/jobs/8848073478?pr=2780

@dlegaultbbry
Copy link
Contributor Author

dlegaultbbry commented May 12, 2023

I'm a bit confused. Looks like the pipeline is not using the latest code or it expects things to be squashed?

@frankmorgner
Copy link
Member

frankmorgner commented May 12, 2023

you may rebase onto #2781, which fixes the CI problem

@dlegaultbbry dlegaultbbry force-pushed the develop/pkcs11_tool_cipher_test branch from 31a79d1 to 009a232 Compare May 12, 2023 14:07
Jakuje
Jakuje reviewed May 16, 2023
View reviewed changes
Copy link
Member

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During make check, there are some basic tests executed against the softhsm pkcs11 module. The pkcs11-tool --test is one of them, but is now expected to fail for now. Can you check how it is running with your changes?

https://github.com/OpenSC/OpenSC/blob/master/tests/test-pkcs11-tool-test.sh

From the CI side, it would be probably good to add some cat tests/*.log to see the results also in CI after this line:

https://github.com/OpenSC/OpenSC/blob/master/.github/build.sh#L54

@frankmorgner frankmorgner merged commit 330ef0b into OpenSC:master Aug 15, 2023
@xhanulik xhanulik mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jakuje Jakuje Jakuje left review comments

@frankmorgner frankmorgner frankmorgner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dlegaultbbry @frankmorgner @Jakuje