pkcs11: Do not use colons in the token info label #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
nss-colons
branch
2 times, most recently
from
bb1d9f7 to
66afffc
Compare
frankmorgner
requested changes
Apr 26, 2023
src/pkcs11/framework-pkcs15.c
Outdated
| * TOKEN_INFO label so replace them here */ | ||
| for (int i = 0; i < 32; i++) { | ||
| if (slot->token_info.label[i] == ':') { | ||
| slot->token_info.label[i] = '_'; |
Member
There was a problem hiding this comment.
I think underscores are very unpleasant in user messages. Could we maybe agree on replacing that just with a space (my preferred option) or with .?
Member
Author
There was a problem hiding this comment.
Sure. I used the _ as suggested by @mouse07410 but you are right that using other character might be more user-friendly. I am afraid that whitespace might be confusing so I am for the . (updated now).
The NSS can not handle tokens with colons in token info labels because it is using colon as a separator for token info label and object label. Fixes: OpenSC#2725 More information available in the following NSS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1817553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSS can not handle tokens with colons in token info labels because it is using colon as a separator for token info label and object label.
Fixes: #2725
More information available in the following NSS bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1817553
Checklist