Skip to content

Fix OpenPGP select data #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankmorgner merged 2 commits into from
Apr 18, 2023
Merged

Fix OpenPGP select data #2753

frankmorgner merged 2 commits into from
Apr 18, 2023

Conversation

@frankmorgner
Copy link
Member

@frankmorgner frankmorgner commented Apr 14, 2023

  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@frankmorgner frankmorgner mentioned this pull request Apr 14, 2023
Closed
Jakuje
Jakuje approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Jakuje Jakuje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Please, remind me with the next release that I should test the Nitrokey/Gnuk token I have in my drawer. For some reason, I missed that one while testing the 0.23.0: https://github.com/OpenSC/OpenSC/wiki/Smart-Card-Release-Testing#opensc-0230 🤦
Verified that this solves the issue with my token.

@frankmorgner frankmorgner merged commit b83c358 into OpenSC:master Apr 18, 2023
@xhanulik xhanulik mentioned this pull request Jul 3, 2023
Closed
@ya-isakov
Copy link
Contributor

ya-isakov commented Dec 25, 2023

Hello! I found a bug, in this change, while I was debugging related issue on Yubikey (#2969). It seems that this change is ignoring any errors from SELECT DATA, but, such errors might indicate that select failed, so, next GET_DATA will read same cert with id 0, as it would read without SELECT DATA. I found this issue in XCA - when I was importing attestation certs from my Yubikey, first (AUT) imported successfully, but when I was importing SIG, it complained, that such cert was already imported as AUT - I compared both certs, and they were the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frankmorgner @ya-isakov @Jakuje