-
Notifications
You must be signed in to change notification settings - Fork 803
Remove onepin-opensc-pkcs11 #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ebd6795 to
e0d90c9
Compare
|
I've now successfully tested all major platforms. Everything works as expected. I've noticed that the PKCS#11 module generates too many notifications for removal/insertion events. That's removed now as well. @Jakuje, @dengert, please let me know if you think that removing onepin-opensc-pkcs11 may cause any trouble for users. |
|
I will notifiy our test team |
Jakuje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, fix the typos. Otherwise it looks good.
08b57fa to
e2569e8
Compare
|
typos are fixed. |
|
Please, remove also the onepin from the spec file in https://github.com/OpenSC/OpenSC/blob/master/packaging/opensc.spec#L164 so we can have the CI passing. |
|
PIV should be fine. Only uses 1 pin |
|
Let's still wait for @metsma 's feedback |
Can we filter Chrome to? |
|
I did not look into the details, but this sounds like a user interface change that should not be ignored. So i suggest a "symlink" or a "deprecation wrapper". If the module disappears ... we will have an issue with any config in any application that is configured to use it. |
Indeed it is, that's why I asked for opinions above. We can surely implement some temporary workarounds, but I fear that those are hard to maintain given the different platforms we support and that I don't see them go away once they are in place. Hence, I personally would opt for a possible breaking change nevertheless. |
With all the browser forks it could get crazy quickly, but it is possible, for sure. But, AFAIK, problems have only been reported for Firefox.... |
We have only official chrome in testing matrix. Chromium uses SNAP in Ubuntu and we don't supprt this configuration. |
Indeed such things are hard to get rid of. But i would still like to ask for some help for end users and distributors. But these modules are mentioned in all sorts of management scripts that configure browsers (many of them) and other applications, some of them proprietary ... Think of ansible or puppet and alike. These scripts will have to work over generations and flavors of Linux, and maybe other OSs. And they will have to deal with creating new configuration and updating old. Not even to mention manual configuration that people have somewhere, did after reading whatever google did spit out ... a forum/blog. I am afraid the user-interface change might be big and hard to handle for distros, admins, and "did something funny" end-users. |
|
@henning-schild I've added the onepin module as link/copy to the installation. I need to verify the Windows installer, however. |
Thanks so much. If i read that last commit correctly it is only about compatibility and not about deprecation. I sure hope the old name can be deprecated one day, or kept forever and not causing too much trouble over time. |
|
@metsma , could you please elaborate what you mean by
Do you think OpenSC should behave like the onepin module in Chrome as well? If so, why? |
Because chrome is using NSS for accessing hardware tokens as far as I know. |
|
Yes. On linux Chrome uses NSS |
|
Thank you for the clarification! Addendum: gnome evolution uses the SmartCard too, I think it does so via the NSS database (like Chrome). Maybe it should be handled as well? But who knows how many apps use the nssdb... |
|
@frankmorgner our test team reports that Firefox and Chrome still request 2 pins (PIN1, PIN2) on authentication. |
I assume you mean that FF/Chrome are requesting the two PINs although only one would be needed for authenticating to a specific site. If so, it sseems that although OpenSC is considered to have the certificates friendly-ish readable, the user experience is still poor. Then, I would try to extend this PR to also recognize |
Yes
I think this will cover most. Maybe add configure option to extend this list. There are other forks available (Tor, Opera etc) |
Wouldn't the problem show up in a potentially unlimited number of applications that use NSS? E.g. opera, thunderbird, evolution, some vpn clients, electron-based apps, etc. Listing them all in opensc seems impossible, perhaps there could be a config somewhere :S |
|
I have symlinked opensc-pkcs11.so to the onepin variant on my systems because too many applications had problems. Applications I have in use: AFAIR all of those apps had the multipe-pin-requested problems. |
|
I think a reasonable good default regular expression for matching the executable's name would work and could be made configurable. Matching all NSS programs, would not make sense, because in E-Mail applications you want to do signing and encryption even if multiple PINs are involved. |
Identifies Firefox, Chrome, Chromium for using the previous onepin-mode
this is getting too annoying with multiple PKCS#11 applications running. We'll let the insertion/removal events be handled by opensc-notify.
|
|
@metsma , could you trigger your test team, please? |
The onepin-opensc-pkcs11 constantly leads to confusion with users, because it is not obvious which opensc module to choose. This PR uses the running program's name to check whether the onepin configuration is needed, i.e. it checks whether the PKCS#11 module is running inside firefox.
The OpenSC tools are refactored so that they can output debug messages even before to a reader (i.e. directly after
sc_context_create().Checklist