feat(pkcs11-tool): testing HMAC #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Jakuje merged 4 commits into OpenSC:master from AlexandreGonzalo:trustonic_pkcs11_hmac

Nov 17, 2022

AlexandreGonzalo commented Nov 14, 2022

Hi All,

I wanted to test HMAC signature and verification with the new version of the pkc11-tool and I found several issues.

We need to add MF_GENERIC_HMAC_FLAGS for CKM_MD5_HMAC
We need --usage-sign for secret keys involved in HMAC operations
It would be great if we can add the CKM_SHA3_XXX_HMAC mechanisms definitions.

Checklist

Documentation is added or updated
New files have a LGPL 2.1 license statement
PKCS#11 module is tested
Windows minidriver is tested
macOS tokend is tested

alegon01 added 3 commits

November 14, 2022 16:23


          feat(pkcs11-tool): add CKM_SHA3_XXX_HMAC mechanisms

6fe4afd


          feat(pkcs11-tool): --usage-sign is also for secret keys

31197f1


          feat(pkcs11-tool): add MF_GENERIC_HMAC_FLAGS for CKM_MD5_HMAC

a6b1a86

AlexandreGonzalo commented

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

AlexandreGonzalo commented

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

AlexandreGonzalo commented

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

AlexandreGonzalo commented

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved

AlexandreGonzalo commented

View reviewed changes

src/tools/pkcs11-tool.c Outdated Show resolved Hide resolved


          feat(pkcs11-tool): add MF_GENERIC_HMAC_FLAGS wherever it is required

0b16bda

Jakuje approved these changes

View reviewed changes

frankmorgner approved these changes

View reviewed changes

Member

Jakuje commented Nov 17, 2022

Thank you for your contribution!

Jakuje merged commit 454d8b5 into OpenSC:master

AlexandreGonzalo deleted the trustonic_pkcs11_hmac branch

February 13, 2025 09:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet