-
Notifications
You must be signed in to change notification settings - Fork 803
[pkcs11-tool] CKO display serial number #2630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkcs11-tool] CKO display serial number #2630
Conversation
|
can we do this without being dependant on OpenSSL? |
|
can you rebase the changes on current master to remove the needless commits (adding support for SHA3, merge commits)? |
Fixes CID 377385, Thanks coverity
Fixes CID 374845, Thanks coverity
fuzz_pkcs15init uses API that is not exported by libopensc.
Local build on RHEL8 and Fedora36 fails with errors on these two tests.
Issue OpenSC#2517 reports that minidriver may be presented with new handles to PCSC, even if card is moved from one reader to another. The previous code assumed a change in handles would always point at same reader. and if reader was changed, caller would do two operations: card is removed from one reader i.e. call CardDeleteContext and some time later when card is inserted, call CardAcquireContext. Thus previous code would not to call reinit_card_for. But this is not the case. So when handles change, the new handles are used to probe the new reader to obtain reader name to compare to old reader name. If they are the same returns to not call reinit_card. If they are different returns to call reinit_card. The assumption is if card is removed, it could be modified on another system then inserted on original system which changed data.
This fixes an omission in e05574d. The names of these files have changed, so they are not deregistered from LaunchServices and uninstalled when running the opensc-uninstall script.
`launchctl remove` is executed by the root user. This will not affect loaded LaunchAgents of the logged-in user.
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Signed-off-by: Alex <[email protected]>
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
I created this new PR |
I did the same as getSUBJECT() above and it is an easy win. |
I am using the pkcs11-tool to list the certificates stored in my PKCS#11 token.
I have this patch which displays the certificate serial number and maybe that's something which could be merged to master.
Certificate Object; type = X.509 cert
subject: DN: C=FR, ST=PACA, L=Valbonne, O=Trustonic, CN=*.trustonic.com
serial: 54E67E7F3DB8F07D11D473717C71E057FD7D22C9
ID: 01
Checklist