customactions.cpp - fix ATRs before adding to registry #2628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengert
force-pushed
the
windows-atr-atrmask
branch
from
1ddd9c7 to
4fcb222
Compare
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
dengert
force-pushed
the
windows-atr-atrmask
branch
from
43a91d0 to
12e9ba3
Compare
Member
Author
|
This PR was tested by @pl31 and reported to work in #2626 (comment) |
Jakuje
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2625
OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by
tbin[s] = (tbin[s] & mbin[s]);before adding to registry.This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry.
Changes to be committed:
modified: win32/customactions.cpp
Checklist