Add actions for Packit #2625
Merged
Add actions for Packit #2625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
approved these changes
Oct 24, 2022
dengert
added a commit
to dengert/OpenSC
that referenced
this pull request
Oct 26, 2022
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivelent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
dengert
added a commit
to dengert/OpenSC
that referenced
this pull request
Oct 26, 2022
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivelent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
dengert
added a commit
to dengert/OpenSC
that referenced
this pull request
Oct 26, 2022
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
dengert
added a commit
to dengert/OpenSC
that referenced
this pull request
Oct 27, 2022
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
frankmorgner
approved these changes
Oct 30, 2022
Jakuje
pushed a commit
that referenced
this pull request
Nov 9, 2022
Include a fix for #2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
AlexandreGonzalo
pushed a commit
to AlexandreGonzalo/OpenSC
that referenced
this pull request
Nov 14, 2022
Include a fix for OpenSC#2625 OpenSC definitions of ATRs have been lax in "sc_atr_table" entries by allowing 1 bits in the ATR that need to be 0 bits when used with Windows compare Do the equivalent reduction of the table ATR done in card.c by "tbin[s] = (tbin[s] & mbin[s]);" before adding to registry. This will then allow lax definitions of ATRs to be copied to customactions.cpp and fixed before adding to registry. Changes to be committed: modified: win32/customactions.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration of Packit for testing the build on Fedora was already discussed in #2528.
Since there was a problem with installing the packit-as-a-service app in GH actions for OpenSC, this PR adds separate actions for creating SRPM and building RPM with Packit.
As the local build command that Packit provides does not install
BuildRequiresfrom the spec file nor provide a command for that, there is also a separate script providing the installation of the dependencies.