Skip to content

Fix record based files #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankmorgner merged 7 commits into from
Mar 28, 2023
Merged

Fix record based files #2604

frankmorgner merged 7 commits into from
Mar 28, 2023

Conversation

@frankmorgner
Copy link
Member

@frankmorgner frankmorgner commented Sep 13, 2022

This pull request is based on #2511 and it implements my changes on top of it. That is,

  • sc_read_record and sc_update_record (and their driver call backs) get a new parameter idx for specifying an offset
  • sc_read_record and sc_update_record can now handle big amounts of data that is split up into several chunks written or read with an offset

Currently changes are untested and I'd be happy to hear from @wcosnc whether it works properly now.

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@frankmorgner frankmorgner force-pushed the fix_record_based_files branch 3 times, most recently from 387399e to d3303b0 Compare September 13, 2022 11:45
Jakuje
Jakuje reviewed Sep 21, 2022
View reviewed changes
Jakuje
Jakuje reviewed Oct 6, 2022
View reviewed changes
@Jakuje
Copy link
Member

Jakuje commented Feb 24, 2023

rebase would be needed to resolve conflicts and fix the isoapplet test though

@frankmorgner frankmorgner force-pushed the fix_record_based_files branch from 7d388a1 to 8b79e4f Compare February 27, 2023 08:09
@frankmorgner
Copy link
Member Author

frankmorgner commented Feb 27, 2023

rebase would be needed to resolve conflicts and fix the isoapplet test though

done

@frankmorgner frankmorgner force-pushed the fix_record_based_files branch from 8b79e4f to f32f39e Compare February 28, 2023 10:38
@Jakuje
Copy link
Member

Jakuje commented Mar 28, 2023

is this ready to merge?

@frankmorgner frankmorgner merged commit 5e06acb into OpenSC:master Mar 28, 2023
@frankmorgner frankmorgner mentioned this pull request Apr 13, 2023
Closed
@xhanulik xhanulik mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jakuje Jakuje Jakuje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frankmorgner @Jakuje