Update card-piv.c with PIVKey ATRs for current cards #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to Issue OpenSC#1531, PIVkey was contacted to provide the list of ATRs for curent PKvKey devices. [email protected] provided list of ATRs which included previously known cards. Some of these ATRs may be used by other card drivers. But will only be accepted by card-piv.c if the card responds to a SELECT PIV AID. On branch PIVKey-ATR Changes to be committed: modified: card-piv.c
frankmorgner
approved these changes
Sep 9, 2022
Jakuje
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1531 starting at: #1531 (comment)
(This should have been a new issue, as the symptoms where the same, but causes were different.)
Card and applet are from PIVKey, Taglio LLC which has a PIV applet, which does not handle Select AID correctly and loses login state when a second Select AID is sent to the card.
card-piv.c can handle this if it knows the applet is from PIVKey. The only way today is from the ATR.
PIVKey was contacted and [email protected] provided list of ATRs which included previously known listed cards.
Note: Some of these cards may be used for other applets or even other vendors version of a PIV applet. But will only
be accepted by card-piv.c if the card responds to a SELECT PIV AID.
User reported in #1531 (comment) that adding ATR to opensc.conf worked. His card's ATR is in the new list in this commit.
On branch PIVKey-ATR
Changes to be committed:
modified: card-piv.c
Checklist