To support feitian epass2003 keys with cos of fips. #2543
Conversation
Support feitian fips mode of epass2003.
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
there are also many formatting problems. Please, review the surrounding code for reference how the code should be formatted, mostly around braces. Remove any space indentation. I mentioned couple of comments inline.
To provide updated changes, you do not have to create a new PR, just push into the current branch. The PR will get updated.
|
please, rebase on current master to get working CI results also for openssl 3.0 and libressl. |
indent and replace memset in some where
Indent and CMAC interfaces of different OpenSSL versions
xaqfan
left a comment
xaqfan
left a comment
There was a problem hiding this comment.
Indent and cmac interfaces of different OpenSSL versions
indenting
indent and no memset to set one byte.
xaqfan
left a comment
xaqfan
left a comment
There was a problem hiding this comment.
repair indent of lines
repair if indent in aes128_encrypt_cmac function
xaqfan
left a comment
xaqfan
left a comment
There was a problem hiding this comment.
repair if indent in aes128_encrypt_cmac function
Merge if statement blocks
xaqfan
left a comment
xaqfan
left a comment
There was a problem hiding this comment.
Merge if statement blocks
|
@frankmorgner Thanks @Jakuje @frankmorgner |
xaqfan
left a comment
xaqfan
left a comment
There was a problem hiding this comment.
No reply for a long time.
Submit it again.
|
Thank you. I think we are good. |
4 participants
To support feitian epass2003 keys with cos of fips.