Remove DSA support #2503
Remove DSA support #2503
Conversation
Remove gpk_encode_dsa_key() and support for DSA algorithm
It is never called with `type` argument of value SC_PKCS15_TYPE_PUBKEY_DSA
SC_ALGORITHM_DSA
|
@OpenSC/maintainers any more concerns with this change? Is there anyone who has some card with DSA that is working? |
|
Any strong opinions if we should get this in now or after the next release? So far I did not hear any reasoning why not to remove DSA support, but remaining question is when. I think this PR is in a good shape to be merged, but I do not insist on doing it right away somebody feels an urge to push this through some announcements. But I hope nobody in 2022 is using 1024 bits DSA keys. I still think the current implementation never worked in PKCS#11 as the DSA algorithm was never registred in |
src/libopensc/pkcs15.h
Outdated
| #define SC_PKCS15_TYPE_PUBKEY_EC 0x204 | ||
| #define SC_PKCS15_TYPE_PUBKEY_EDDSA 0x205 | ||
| #define SC_PKCS15_TYPE_PUBKEY_XEDDSA 0x206 | ||
| #define SC_PKCS15_TYPE_PUBKEY_GOSTR3410 0x202 |
There was a problem hiding this comment.
sorry for the late comment. Should we keep the old identifiers here as well?
There was a problem hiding this comment.
As @Jakuje mentioned above, it should probably stay as it was originally, it's fixed already.
There was a problem hiding this comment.
With this change reverted, we need to adjust also the pkcs15-tool change, which is using these constants for key type labels.
There was a problem hiding this comment.
Thanks for pointing out, fixed.
Structures for DSA keys, macros and encoding/decoding function
frankmorgner
left a comment
frankmorgner
left a comment
There was a problem hiding this comment.
I think we're good to include this in the next release, too.
3 participants
Fixes #2454
PR removes support for DSA, mostly generic code,
pkcs15-init,pkcs15-tooland the support in GPK and epass2003 drivers.Checklist