pkcs11-tool: consistent handling of secret key attributes #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When support for unwrapping secret keys was added in 9136878 (as part of OpenSC#2268), the `--usage-decrypt` and `--usage-wrap` options were used to toggle the `CKA_{ENCRYPT,DECRYPT}` and `CKA_{WRAP,UNWRAP}` attributes in the object template passed to the module. In contrast, when a secret key object is generated (`--keygen`) or created (`--write-object`), the same attributes are unconditionally set to true or omitted respectively, regardless of any specified `--usage-*` option. To make this handling consistent, use the approach introduced by the unwrap command and let the user specify the attributes, defaulting to only setting `CKA_{ENCRYPT,DECRYPT}` if no usage was specified. The documentation was amended to reflect the behavior of `--usage-decrypt`.
Jakuje
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support for unwrapping secret keys was added in 9136878 (as part
of #2268), the
--usage-decryptand--usage-wrapoptions were used totoggle the
CKA_{ENCRYPT,DECRYPT}andCKA_{WRAP,UNWRAP}attributes inthe object template passed to the PKCS#11 module.
In contrast, when a secret key object is generated (
--keygen) orcreated (
--write-object), the same attributes are unconditionally setto true or omitted respectively, regardless of any specified
--usage-*option.
To make this handling consistent, use the approach introduced by the unwrap
command and let the user specify the attributes, defaulting to only setting
CKA_{ENCRYPT,DECRYPT}if no usage was specified.The documentation was amended to reflect the behavior of
--usage-decrypt.Checklist