Skip to content

Add support for SHA3* in pkcs11-tool. #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jakuje merged 1 commit into from
Dec 20, 2021
Merged

Add support for SHA3* in pkcs11-tool. #2467

Jakuje merged 1 commit into from
Dec 20, 2021

Conversation

@AlexandreGonzalo
Copy link

@AlexandreGonzalo AlexandreGonzalo commented Dec 13, 2021

Hi OpenSC team,
It's been a long time since my last PR.
Last year, I added the support for many algorithms with SHA3 in our Trustonic TEE PKCS#11 HSM.
For my own testing, I modified the pkcs11-tool and libp11.
In this PR, I am pushing all the changes for the pkcs11-tool.
Is it something that you want?
Should I also start the PR for the libp11?
Best Regards,
Alexandre.

@Jakuje
Copy link
Member

Jakuje commented Dec 13, 2021

Looks good. Indeed, the SHA3 support is a useful as it is finally standardized. The smart card adoption of this algorithm did not get far yet though, but the pkcs11-tool should be considered more generic so having this in makes sense. The same for libp11.

I think the test failure is just flaky so lets ignore it for now.

@AlexandreGonzalo
Copy link
Author

AlexandreGonzalo commented Dec 13, 2021 •
edited
Loading

Looks good. Indeed, the SHA3 support is a useful as it is finally standardized. The smart card adoption of this algorithm did not get far yet though, but the pkcs11-tool should be considered more generic so having this in makes sense. The same for libp11.

We don't know yet when our customers will start to use the SHA3 algorithms, it may start sooner than expected.
I will prepare the PR for libp11 tomorrow.

I think the test failure is just flaky so lets ignore it for now.

This test passed for my second PR which includes the same patch for SHA3. I don't think that this failure is linked to my changes.
Thanks for the review.

@AlexandreGonzalo AlexandreGonzalo mentioned this pull request Dec 13, 2021
Merged
@Jakuje Jakuje merged commit 846ee37 into OpenSC:master Dec 20, 2021
@xhanulik xhanulik mentioned this pull request Jul 12, 2022
Closed
@AlexandreGonzalo AlexandreGonzalo deleted the trustonic_pkcs11_sha3 branch February 13, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankmorgner frankmorgner frankmorgner approved these changes

@Jakuje Jakuje Jakuje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexandreGonzalo @Jakuje @frankmorgner