-
Notifications
You must be signed in to change notification settings - Fork 803
Unbreak nPA detection #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak nPA detection #2463
Conversation
Jakuje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to squash the fixup commits before merging the changes or are we fine merging it as it is?
Some cards don't accept selection from MF (P1=08), but only relative selection (P1=02). This breaks the default implementation of sc_enum_apps() for those cards. Use a default EF.DIR for detection and initializing the card's apps.
…_sfid fixes ignoring 6282 due to automatic retry of reading the requested number of bytes in sc_read_binary
Done. The only change I was not able to verify is whether or not 043a7b0 is the correct fix to the strict aliasing problem... |
I think it is correct. These are very similar changes I did in 2fa6700 when I was tackling this issue in the rest of the code. But I do not build the openpace so I probably did not hit this issue. Did you try with |
|
Sorry for the late feedback. No, I wasn't able to see the warnings for the unmodified code with gcc 10.3.0 and the above flags. Could we make this strict build part of the CI process? |
|
np. I was adding the The simplest would probably be to add one more target to linux with building also openpace (It is not in the current ubuntu version in GH). |
Fixes #2461
Checklist