-
Notifications
You must be signed in to change notification settings - Fork 803
Fuzzer for configuration file #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
approved these changes
Oct 20, 2021
Member
|
@frankmorgner what do you think? |
…bled For testing purposes, fuzzers take files as input which feed LLVMFuzzerTestOneInput function.
In case that called function print out some data
buf_addch() store values on bp->bufcur and bp->bufcur + 1 but check size of the buffer only for bp->bufcur.
Issue found by calling scconf_string_parse() with "name =\n\n\nvalue,value;" as an input string. scconf_parse_token() interprets more newline characters as item with type SCCONF_ITEM_TYPE_COMMENT. After that when parsing TOKEN_TYPE_STRING, if parser->state is STATE_VALUE, scconf_list_add() adds list into that item. During freeing scconf_context structure, above described item is freed as SCCONF_ITEM_TYPE_COMMENT and created list causes memory leak. To fix this, scconf_parse_token() checks type of item before adding into list. When parsing is done, scconf_parse_reset_state() frees values in parser->name and parser->key.
Jakuje
approved these changes
Nov 2, 2021
frankmorgner
approved these changes
Nov 3, 2021
Member
|
looks good, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple fuzzer with basic corpus for parsing configuration file using function
scconf_parse_string().When no
--enable-fuzzingoption, fuzzers are built withfuzzer.cas simple programs which take file as source for buffer, that is then passed toLLVMFuzzerTestOneInput().stdoutin fuzzers will be closed, when fuzzing is enabled.Fixes #2402
Checklist