Disable old card drivers and PKCS#15 emulators #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Jakuje merged 6 commits into OpenSC:master from xhanulik:disable-old-drivers

Sep 7, 2021

Member

xhanulik commented Aug 18, 2021

This PR disables old and recently unmodified card drivers (card-*.c) and their counterpart PKCS#15 emulators (pkcs15-*.c), and adds boilerplate for disabling old emulators.

Developer activity below tracks active developing and maintaining a card driver/emulator, excluding generic changes and fuzzing/static analysis fixes:

card-akis.c: modified 2007
card-asepcos.c: modified 2010
card-atrust-acos.c (pkcs15-atrust-acos.c): modified 2008
card-flex.c: modified 2010
card-gpk.c (pkcs15-gemsafeGPK.c): modified 2007
card-incrypto34.c: modified 2007
card-westcos.c (pkcs15-westcos.c): modified 2010
pkcs15-actalis.c and pkcs15-tccardos.c: Emulators detect card according to card name, which was changed in card-cardos.c in eee4964 (2017) and they were not updated since this change accordingly, which implies no latest use.

There was no recent user activity (issues, bug reports) related to the mentioned cards.
Disabled drivers and emulators can be enabled in opensc.conf.
Filtering of PKCS#15 emulators in pkcs15-emulator-filter.c enables emulators according to opensc.conf file.

Checklist

Documentation is added or updated
New files have a LGPL 2.1 license statement

xhanulik added 5 commits

August 18, 2021 17:34


          Disable old cards drivers

d7262de

Currently disabled card drivers
due to no recent user or developer activity:
- akis
- asepcos
- atrust-acos
- flex
- gpk
- incrypto34
- westcos


          Add boilerplate for disabling old pkcs15 emulators

83a6d95

Filtering of enabled pkcs15 emulators according to conf file.
Currently disabled:
- westcos
- gemsafeGPK
- atrust-acos


          Update documentation for disabling pkcs15 emulators

aceca56


          Add unit tests for filtering pkcs15 emulators

34f5f99

Basic unit tests for filtering enabled emulators according to conf file


          Disable pkcs15 emulators for Actalis and TC CardOS

1f02b8f

Emulators detect card according to string "CardOS M4",
which was changed in card-cardos.c (eee4964), but
they were not modified since than accordingly.

Jakuje reviewed

View reviewed changes

src/libopensc/pkcs15-emulator-filter.c

+              						goto out;
+              					break;
+              				}
+              			}

Member

Jakuje Aug 25, 2021

I think we should at least a log warning if we try to add a non-existing emulator. At this moment, it will get silently ignored. Note, that you will need a opensc context for logging in this function.

Member Author

xhanulik Aug 26, 2021

Thank you for pointing out, should be resolved with 86dfd9d


          Improve logging for filtering pkcs15 emulators

86dfd9d

Warnings for exceeding maximum count of filtered emulators
and for trying to add non-existing emulator.

Jakuje approved these changes

View reviewed changes

frankmorgner approved these changes

View reviewed changes

Jakuje merged commit 146e3e1 into OpenSC:master

xhanulik deleted the disable-old-drivers branch

September 19, 2021 15:07

xhanulik mentioned this pull request

Prepare for release 0.23.0 #2426

Closed

Jakuje mentioned this pull request

Athena ASE III gets CKR_TOKEN_NOT_RECOGNIZED #2832

Closed

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for AKIS cards

56a67bf

Remove due to no user and developer activity.
Last relevant modification was f947614
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for AKIS cards

925e7eb

Remove due to no user and developer activity.
Last relevant modification was 7d935df
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Schlumberger Cryptoflex cards

e850e5b

Remove due to no user and developer activity.
Last relevant modification was 7d935df
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

55545f9

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391..

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

a04c61e

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for westcos cards

f1e13d5

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

b957a7e

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391..

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

36647b2

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Schlumberger Cryptoflex cards

6a9dcd0

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

5a41dce

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

ce3eeff

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Westcos cards

f7a8898

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for AKIS cards

591979e

Remove due to no user and developer activity.
Last relevant modification was f947614
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Schlumberger Cryptoflex cards

321d957

Remove due to no user and developer activity.
Last relevant modification was 7d935df
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

510e858

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

4ce5190

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Westcos cards

3ad6178

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik mentioned this pull request

Removal of old card drivers #2885

Merged

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for AKIS cards

0bf868c

Remove due to no user and developer activity.
Last relevant modification was f947614
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

6f9e33d

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

d36ebb3

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Westcos cards

59710a6

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for AKIS cards

75f5df6

Remove due to no user and developer activity.
Last relevant modification was f947614
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for GPK cards

fc215b9

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Incrypto34 cards

3b29407

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

xhanulik added a commit to xhanulik/OpenSC that referenced this pull request


          Remove support for Westcos cards

125cc95

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in OpenSC#2391.

Jakuje pushed a commit that referenced this pull request


          Remove support for AKIS cards

f3d4412

Remove due to no user and developer activity.
Last relevant modification was f947614
and no more changes except general were made.
The driver was disabled in #2391.

Jakuje pushed a commit that referenced this pull request


          Remove support for GPK cards

cce18b4

Remove due to no user and developer activity.
Last relevant modification was a8908b8
and no more changes except general were made.
The driver was disabled in #2391.

Jakuje pushed a commit that referenced this pull request


          Remove support for Incrypto34 cards

3a8f1a3

Remove due to no user and developer activity.
Last relevant modification was a2f622a
and no more changes except general were made.
The driver was disabled in #2391.

Jakuje pushed a commit that referenced this pull request


          Remove support for Westcos cards

48b3122

Remove due to no user and developer activity.
Last relevant modification was c3de15d
and no more changes except general were made.
The driver was disabled in #2391.

emaxx-google commented Jan 26, 2024

Hello, should Wiki articles like https://github.com/OpenSC/OpenSC/wiki/WestCOS be updated accordingly to mention the deletion as well?

Member Author

xhanulik commented Jan 29, 2024

Hello, should Wiki articles like https://github.com/OpenSC/OpenSC/wiki/WestCOS be updated accordingly to mention the deletion as well?

Thanks for noticing, I'll take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet