Skip to content

Conversation

@xhanulik
Copy link
Member

@xhanulik xhanulik commented Aug 3, 2021

This PR removes old card drivers, which were disabled in #1175.

There was no user and developer activity since 2003

except some general fixes on both drivers.

Remove due to no recent user and developer activity,
last driver modification was f761d15
and no more changes except general were made.
The driver was disabled in OpenSC#1175.
Remove support for JCOP/BlueZ cards due to no recent
user or developer activity except general fixes.
Remove due to no user and developer activity,
last relevant driver modification was 30c0943
and no more changes except general were made.
The driver was disabled in OpenSC#1175.
Remove support for MioCOS due to no recent
user or developer activity except general fixes.
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request fixes 4 alerts when merging d0df86c into f43d3f8 - view on LGTM.com

fixed alerts:

  • 4 for FIXME comment

@Jakuje Jakuje requested a review from frankmorgner August 10, 2021 11:33
@Jakuje
Copy link
Member

Jakuje commented Aug 17, 2021

I know that https://github.com/OpenSC/OpenSC/projects/2 talks about disabling compilation of the old drivers, but I do not see a point in keeping some unused code in the repository. If somebody will need these drivers for something, they can be pulled from git history.

@Jakuje Jakuje merged commit 5582cd2 into OpenSC:master Aug 17, 2021
@xhanulik xhanulik deleted the remove-old-drivers branch August 26, 2021 14:01
@frankmorgner
Copy link
Member

I know that https://github.com/OpenSC/OpenSC/projects/2 talks about disabling compilation of the old drivers, but I do not see a point in keeping some unused code in the repository. If somebody will need these drivers for something, they can be pulled from git history.

We want to have the old drivers still available for at least one release cycle where they are disabled (not removed). If they are needed, they can be easily enabled again by the users and they will hopefully yield an issue here. For MioCOS and JCOP, there were no complaints, so they're fine to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants