Add support for (X)EdDSA keys in OpenPGP driver #1960

Jakuje · 2020-02-25T10:14:06Z

This patch set implements first batch of PKCS#11 3.0 features, mostly Ed25519 and curve25519 keys and related algorithms in the OpenSC itself and in the OpenPGP driver (as @jans23 provided me with NitroKey Start, which is equipped with GNUK). The card was initialized using gpg so the card initialization is not in place (yet).

There are many changes across the board including the p11test testsuite, which worked for me fine, but more testing would be appreciated. This is a transcript of p11test with current branch testing sign and derive mechanisms using these new keys:

[jjelen@t470s p11test (eddsa)]$ ./p11test -p 123456
[==========] Running 8 test(s).
[ RUN      ] wait_test
To test wait, run in interactive mode (-i switch).
[  SKIPPED ] wait_test
[ RUN      ] supported_mechanisms_test
[      MECHANISM      ] [ KEY SIZE ] [  FLAGS   ]
[        CKM_*        ] [ MIN][ MAX] [          ]
[SHA_1                ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA224               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA256               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA384               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA512               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[MD5                  ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[RIPEMD160            ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[GOSTR3411            ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[EDDSA                ] [ 255][ 255] [0x00000801] CKF_HW CKF_SIGN
[ECDH1_DERIVE         ] [ 255][ 255] [0x00080001] CKF_HW CKF_DERIVE
[       OK ] supported_mechanisms_test
[ RUN      ] readonly_tests
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [ENC&DECRYPT] [WRAP&UNWR] [ DERIVE ]

[03    ] [Authentication key]
[ EC_E ] [   255] [      ] [[./]  [./] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][  ]]
  [ EDDSA                ] [   [./]    ] [           ] [         ] [        ]

[02    ] [Encryption key]
[ EC_M ] [   255] [      ] [[  ]  [  ] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][./]]
  no usable attributes found ... ignored
 Public == Cert -----^       ^  ^  ^       ^  ^  ^       ^----^- Attributes
 Sign Attribute -------------'  |  |       |  |  '---- Decrypt Attribute
 Sign&Verify functionality -----'  |       |  '------- Enc&Dec functionality
 Verify Attribute -----------------'       '---------- Encrypt Attribute
[       OK ] readonly_tests
[ RUN      ] multipart_tests
[KEY ID] [TYPE] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [LABEL]
[03    ] [EC_E] [   255] [      ] [[./]  [./] ] [Authentication key]
         [ EDDSA                ] [   [./]    ]

[02    ] [EC_M] [   255] [      ] [[  ]  [  ] ] [Encryption key]

 Public == Cert ------------^       ^  ^  ^
 Sign Attribute --------------------'  |  |
 Sign&Verify functionality ------------'  |
 Verify Attribute ------------------------'
[       OK ] multipart_tests
[ RUN      ] ec_sign_size_test
[       OK ] ec_sign_size_test
[ RUN      ] usage_test
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [ENC&DECRYPT] [WRAP&UNWR] [ DERIVE ] [ALWAYS_AUTH]

[03    ] [Authentication key]
[ EC_E ] [   255] [      ] [[./]  [./] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][  ]] [    [  ]   ]

[02    ] [Encryption key]
[ EC_M ] [   255] [      ] [[  ]  [  ] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][./]] [    [  ]   ]
 Public == Cert -----^       ^-----^       ^-----^       ^----^      ^---^
 Sign & Verify Attributes ------'             |            |           |
 Encrypt & Decrypt Attributes ----------------'            |           |
 Wrap & Unwrap Attributes ---------------------------------'           |
 Public and Private key Derive Attributes -----------------------------'
[       OK ] usage_test
[ RUN      ] pss_oaep_test
Token does not support any RSA-PSS or OAEP mechanisms. Skipping.
[  SKIPPED ] pss_oaep_test
[ RUN      ] derive_tests
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ]  [ PUBLIC ] [  DERIVE  ]

[02    ] [Encryption key]
[ EC_M ] [   255] [        ]  [ [  ][./] ]
  [ ECDH1_DERIVE            ] [   [./]   ]
 Public == Cert -----^          ^
 ECDH Derive functionality -----'
[       OK ] derive_tests
[==========] 8 test(s) run.
[  PASSED  ] 6 test(s).
[  SKIPPED ] 2 test(s), listed below:
[  SKIPPED ] wait_test
[  SKIPPED ] pss_oaep_test

 2 SKIPPED TEST(S)
[jjelen@t470s p11test (eddsa)]$ ./p11test -s 1 -p 123456
[==========] Running 8 test(s).
[ RUN      ] wait_test
To test wait, run in interactive mode (-i switch).
[  SKIPPED ] wait_test
[ RUN      ] supported_mechanisms_test
[      MECHANISM      ] [ KEY SIZE ] [  FLAGS   ]
[        CKM_*        ] [ MIN][ MAX] [          ]
[SHA_1                ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA224               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA256               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA384               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[SHA512               ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[MD5                  ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[RIPEMD160            ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[GOSTR3411            ] [   0][   0] [CKF_DIGEST] CKF_DIGEST
[EDDSA                ] [ 255][ 255] [0x00000801] CKF_HW CKF_SIGN
[ECDH1_DERIVE         ] [ 255][ 255] [0x00080001] CKF_HW CKF_DERIVE
[       OK ] supported_mechanisms_test
[ RUN      ] readonly_tests
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [ENC&DECRYPT] [WRAP&UNWR] [ DERIVE ]

[01    ] [Signature key]
[ EC_E ] [   255] [      ] [[./]  [./] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][  ]]
  [ EDDSA                ] [   [./]    ] [           ] [         ] [        ]
 Public == Cert -----^       ^  ^  ^       ^  ^  ^       ^----^- Attributes
 Sign Attribute -------------'  |  |       |  |  '---- Decrypt Attribute
 Sign&Verify functionality -----'  |       |  '------- Enc&Dec functionality
 Verify Attribute -----------------'       '---------- Encrypt Attribute
[       OK ] readonly_tests
[ RUN      ] multipart_tests
[KEY ID] [TYPE] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [LABEL]
[01    ] [EC_E] [   255] [      ] [[./]  [./] ] [Signature key]
         [ EDDSA                ] [   [./]    ]

 Public == Cert ------------^       ^  ^  ^
 Sign Attribute --------------------'  |  |
 Sign&Verify functionality ------------'  |
 Verify Attribute ------------------------'
[       OK ] multipart_tests
[ RUN      ] ec_sign_size_test
[       OK ] ec_sign_size_test
[ RUN      ] usage_test
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ] [PUBLIC] [SIGN&VERIFY] [ENC&DECRYPT] [WRAP&UNWR] [ DERIVE ] [ALWAYS_AUTH]

[01    ] [Signature key]
[ EC_E ] [   255] [      ] [[./]  [./] ] [[  ]  [  ] ] [[  ] [  ]] [[  ][  ]] [    [  ]   ]
 Public == Cert -----^       ^-----^       ^-----^       ^----^      ^---^
 Sign & Verify Attributes ------'             |            |           |
 Encrypt & Decrypt Attributes ----------------'            |           |
 Wrap & Unwrap Attributes ---------------------------------'           |
 Public and Private key Derive Attributes -----------------------------'
[       OK ] usage_test
[ RUN      ] pss_oaep_test
Token does not support any RSA-PSS or OAEP mechanisms. Skipping.
[  SKIPPED ] pss_oaep_test
[ RUN      ] derive_tests
[KEY ID] [LABEL]
[ TYPE ] [ SIZE ]  [ PUBLIC ] [  DERIVE  ]
 Public == Cert -----^          ^
 ECDH Derive functionality -----'
[       OK ] derive_tests
[==========] 8 test(s) run.
[  PASSED  ] 6 test(s).
[  SKIPPED ] 2 test(s), listed below:
[  SKIPPED ] wait_test
[  SKIPPED ] pss_oaep_test

 2 SKIPPED TEST(S)

I tested only PKCS#11 module so for future, there will be certainly needed some work for minidriver (if it can use these keys?), maybe for macOS?

Comments welcomed

Checklist

Documentation is added or updated
PKCS#11 module is tested
Windows minidriver is tested
macOS tokend is tested

Jakuje · 2020-02-25T14:17:30Z

I am working on interoperability tests with SoftHSM, but for now it looks like they announce wrong limits to mechanism key sizes: softhsm/SoftHSMv2#522
Additionally they do not seem to handle correctly the EC_PARAMS: softhsm/SoftHSMv2#523 so before having some interoperability at least with softhsm, it will take some time.

lgtm-com · 2020-02-26T19:03:34Z

This pull request introduces 1 alert when merging 0067663 into 8f4a6c7 - view on LGTM.com

new alerts:

1 for Wrong type of arguments to formatting function

ueno

At first glance, it generally looks good to me. I've added comments but they are mostly cosmetic or questions.

src/libopensc/card.c

src/libopensc/pkcs15-sec.c

src/libopensc/pkcs15-pubkey.c

src/pkcs11/framework-pkcs15.c

src/tools/pkcs11-tool.c

src/libopensc/card-openpgp.c

src/tests/p11test/p11test_case_ec_derive.c

ueno

Looks good to me now (though my review is superficial)

src/libopensc/card-openpgp.c

alex-nitrokey · 2020-03-24T12:45:16Z

I tested this PR with naive key generation attempt but I did not had any luck:

$ pkcs15-init --verify --auth-id 3 --pin 12345678 --delete-objects privkey,pubkey --id 3 --generate-key ec/cv25519
Using reader with a card: Nitrokey Nitrokey Start (FSIJ-1.2.10-67111047) 00 00
NOTE: couldn't find pubkey 03 to delete
Deleted 1 objects
Failed to generate key: Not supported
$ pkcs15-init --verify --auth-id 3 --pin 12345678 --delete-objects privkey,pubkey --id 2 --generate-key ec/ed25519
Using reader with a card: Nitrokey Nitrokey Start (FSIJ-1.2.10-67111047) 00 00
NOTE: couldn't find pubkey 02 to delete
Deleted 1 objects
Failed to generate key: Card command failed

Of course, I can provide logs but at first I wanted to know if I am just doing it wrong?

Jakuje · 2020-03-24T13:00:20Z

The current version implements only reading and using of existing keys (I used keys generated through gpg tools). The key deletion and generation is not implemented in current code. I will check the rest of comments ruing next days/weeks.

alex-nitrokey · 2020-03-24T13:05:19Z

I see, makes sense. Do you need any help in implementing this or do you plan to do so yourself?
btw thanks a lot for introducing cv25519 to OpenSC :)

Jakuje · 2020-03-24T13:49:16Z

I would like to continue working on that, but just now, I have few other things to catch up (and test and review @dengert changes -- I left the token in work so I need to stop there to pick it up in coming days). If you or somebody else would like to follow up on the keygen and missing functions feel free to do the work :) I hope we will be able to move on with review, testing and merging during this week.

alex-nitrokey · 2020-03-24T14:44:19Z

The current version implements only reading and using of existing keys (I used keys generated through gpg tools).

A little heads up: as far as I can see only the slot 1 key is recognized so far. At least this is all I got for a key that got all three slots equipped with keys by GnuPG beforehand.

$ pkcs15-tool -c -k
Using reader with a card: Nitrokey Nitrokey Start (FSIJ-1.2.10-67111047) 00 00
Private EDDSA Key [Signature key]
        Object Flags   : [0x03], private, modifiable
        Usage          : [0x20C], sign, signRecover, nonRepudiation
        Access Flags   : [0x1D], sensitive, alwaysSensitive, neverExtract, local
        FieldLength    : 255
        Key ref        : 0 (0x00)
        Native         : yes
        Auth ID        : 01
        ID             : 01
        MD:guid        : eaa385f7-cc9d-062a-2353-4c8ebb133f8a

dengert · 2020-03-24T17:24:45Z

What do these report:
pkcs11-tool --list-slots
pkcs15-tool --ist-pins
pkcs15-tool --dump

You might need to add --auth-id <arg> to your pkcs15-tool -c -k

dengert · 2020-03-24T17:35:58Z

Using `gpg4win (3.1.1) on Windows 10, (command line following the Nitro instructions)to populate the Nitro Pro with 3 keys.
Using Open SC master 3/32/2020 d5ecafc I can see 3 keys.

pkcs15-tool -c -k
Using reader with a card: Nitrokey Nitrokey Pro (0000000000000000000080B8) 00 00
Private EC Key [Signature key]
	Object Flags   : [0x03], private, modifiable
	Usage          : [0x20C], sign, signRecover, nonRepudiation
	Access Flags   : [0x1D], sensitive, alwaysSensitive, neverExtract, local
	FieldLength    : 0
	Key ref        : 0 (0x00)
	Native         : yes
	Auth ID        : 01
	ID             : 01
	MD:guid        : 80a469b7-f397-03e4-7fc7-3275067bbe94

Private EC Key [Encryption key]
	Object Flags   : [0x03], private, modifiable
	Usage          : [0x22], decrypt, unwrap
	Access Flags   : [0x1D], sensitive, alwaysSensitive, neverExtract, local
	FieldLength    : 0
	Key ref        : 1 (0x01)
	Native         : yes
	Auth ID        : 02
	ID             : 02
	MD:guid        : d85c0417-97a1-1d74-c593-0305f9ec101a

Private RSA Key [Authentication key]
	Object Flags   : [0x03], private, modifiable
	Usage          : [0x222], decrypt, unwrap, nonRepudiation
	Access Flags   : [0x1D], sensitive, alwaysSensitive, neverExtract, local
	ModLength      : 2048
	Key ref        : 2 (0x02)
	Native         : yes
	Auth ID        : 02
	ID             : 03
	MD:guid        : 0afc7d32-41d6-5d4c-15e8-f76cb7bd75cc

alex-nitrokey · 2020-03-26T09:03:36Z

Using `gpg4win (3.1.1) on Windows 10, (command line following the Nitro instructions)to populate the Nitro Pro with 3 keys.

But this PR is about adding curve25519 which is only support by NK Start/Gnuk devices, isn't it?
You are trying a NK Pro which is working fine for the corresponding curves for me as well.

alex-nitrokey · 2020-03-26T09:06:34Z

What do these report:

All these only show the PIN slots and the one signature slot I was mentioning before.

dengert · 2020-03-26T12:54:31Z

@alex-nitrokey Nitro sent me a Nitrokey Pro. The comment was a hint that if I they send me a card, which supports curve25519 I could help debug it too.

alex-nitrokey · 2020-03-26T12:57:44Z

I see, did not understand the hint :)
We would be glad to provide you with a device. Please just send me a mail with your address to support at nitrokey.com

Jakuje · 2020-05-19T17:34:48Z

I rebased this patch set on top of master. We will probably not get everything in before 0.21.0, but I would like to get in at least the first bunch of fixup commits not directly related to the eddsa support (if preferred, I can submit them in separate PR).

frankmorgner · 2020-05-20T15:17:46Z

lgtm brought up a simple issue:

frankmorgner

Looks very nice. I had only some minor comments.

Indeed, this PR would be a nice feature for the next release. I'd like to hold it back and concentrate on the bugfixes #1999 and #1963 ...

src/libopensc/card-openpgp.c

src/pkcs11/framework-pkcs15.c

lgtm-com · 2020-05-25T11:40:03Z

This pull request introduces 1 alert when merging 964caae into 0a17188 - view on LGTM.com

new alerts:

1 for Wrong type of arguments to formatting function

Jakuje · 2020-05-25T12:38:58Z

Fixed previous comments. Last failing test is now the osx build because missing build signing keys.

Since 09a594d bringing ECC support to openPGP card, it did not count with GNUK. This adds exception for GNUK to unbreak ECC signatures as GNUK presents BCD version < 3.

…9 keys (with few tweaks) The Ed25519 implementation in SoftHSM is now broken /non-interoperable. After fixing that, the interoperability tests should work with this script: * SoftHSMv2#528: Avoid creating duplicate mechanisms * SoftHSMv2#522: Fix advertised min and max mechanism sizes according to final PKCS#11 3.0 specification * SoftHSMv2#526: Adjust EDDSA code to return valid EC_PARAMS according to the final PKCS OpenSC#11 3.0 specification

card-opennpgp.c and pkcs15-openpgp.c have a strang way of using sc_object_id_t to store what they call a binary_oid or oid_binary. It is used to convert the EC curve asn1 returned in the cxdata. This code uses asn1_decode_object_id to use sc_object_id_t as used in the rest of the code. The code and ec_curve tabes in card-openpgp.c where not changed. pkcs15-openpgp.c was channge si to can use: algorithm_info = sc_card_find_ec_alg(card, 0, &oid); to retried the key_length to add to the pubkey and prkey entries. The EC and EDDSA needs (i.e. field_length) to run. On branch eddsa Your branch is up to date with 'Jakuje/eddsa'. Changes to be committed: modified: card.c modified: pkcs15-openpgp.c

… typo

This is the current interpretation of the specs after talking with several members of PKCS OpenSC#11 TC.

This reverts commit 98beb86.

Jakuje · 2021-03-01T15:03:48Z

Rebased and tested with Nitrokey Start. There were some conflicts around the things modified recently by @popovec around support for additional EC mechanisms so I would like you to have a look if it makes sense. Here, we have a new keys EC_MONTGOMERY that are using EC algorithms but only CKM_ECDH1_DERIVE and not the CKM_EC, which needed the additional conditions in register_ec_mechanisms().

frankmorgner · 2021-03-17T14:09:35Z

The resolved conflicts are looking good from my perspective, but let's wait a bit to see if @popovec has some comments.

popovec · 2021-03-17T14:43:21Z

I have checked b8266a4, I did not find any problem that would interfere with the functionality of already mentioned modifications for EC mechanisms (ECDSA verify, ECDSA Signatures with hashes). I propose to accept this PR.

Jakuje force-pushed the eddsa branch from 0067663 to 09aa001 Compare February 27, 2020 13:56

ueno suggested changes Feb 27, 2020

View reviewed changes

Jakuje force-pushed the eddsa branch from 09aa001 to 7422aa7 Compare February 28, 2020 13:52

ueno approved these changes Feb 28, 2020

View reviewed changes

szszszsz mentioned this pull request Mar 14, 2020

Cannot sign message with ECC P384 using OpenPGP v3.3 #1982

Closed

alex-nitrokey reviewed Mar 24, 2020

View reviewed changes

src/libopensc/card-openpgp.c Outdated Show resolved Hide resolved

Jakuje mentioned this pull request Apr 21, 2020

Fuzzing issues to be able to improve oss-fuzz integration #2012

Merged

3 tasks

szszszsz mentioned this pull request Apr 28, 2020

openpgp: pkcs11-tool --keypairgen ec keys not working #2020

Closed

Jakuje force-pushed the eddsa branch 2 times, most recently from ccefc05 to eb723f3 Compare May 19, 2020 17:33

Jakuje force-pushed the eddsa branch from eb723f3 to edf0901 Compare May 20, 2020 08:13

frankmorgner approved these changes May 20, 2020

View reviewed changes

src/libopensc/card-openpgp.c Outdated Show resolved Hide resolved

src/libopensc/card-openpgp.c Outdated Show resolved Hide resolved

src/pkcs11/framework-pkcs15.c Show resolved Hide resolved

Jakuje force-pushed the eddsa branch from 74ecc89 to 964caae Compare May 25, 2020 11:23

Jakuje and others added 20 commits March 1, 2021 15:42

pkcs11-tool: Support for new (X)EdDSA keys

5178e74

opensc-tool: Support for new (X)EdDSA keys

5d5c391

openpgp: Use only Derive mechanism for curve25519 keys

a965829

openpgp: Unbreak EC algorithms for GNUK

e7d390f

Since 09a594d bringing ECC support to openPGP card, it did not count with GNUK. This adds exception for GNUK to unbreak ECC signatures as GNUK presents BCD version < 3.

openpgp: Set reasonable usage for (X)EdDSA keys

32ec1f9

p11test: Add support for EdDSA keys

485b6cf

pkcs11-tool: Add support for (X)EDDSA key generation

35cfc29

framework-pkcs15: Fix typo in comment

8c4d325

openpgp: Check return code of OID decoding from ASN1

9bd139d

openpgp: Do not fail hard if unknown algorithm is encountered and fix…

64b61a7

… typo

openpgp: Correctly handle curve25519 keys

73e283b

unittests: Briefly test asn1_encode

a020b85

asn1: Do not crash on invalid arguments

cb8c764

openpgp: Rewrite decipher/derive to use asn1 functions

ae771a1

pkcs11: Rewrite ec params to use sc_asn1_put_tag()

c39e31b

Change (X)EDDSA EC_PARAMS encoding to OID

56af7de

This is the current interpretation of the specs after talking with several members of PKCS OpenSC#11 TC.

p11test: Fix one-off comparison

0ce245a

Revert "fixed atrmask for gnuk"

b8266a4

This reverts commit 98beb86.

Jakuje force-pushed the eddsa branch from c9749a4 to b8266a4 Compare March 1, 2021 14:59

frankmorgner mentioned this pull request Mar 9, 2021

Towards new release 0.22.0 #2247

Closed

frankmorgner approved these changes Mar 17, 2021

View reviewed changes

frankmorgner merged commit 5f9085f into OpenSC:master Mar 22, 2021

ya-isakov mentioned this pull request Apr 3, 2021

OpenPGP 3.4+: Enable ed25519/curve25519 support #2286

Merged

3 tasks

ya-isakov mentioned this pull request Apr 20, 2021

[RFC] OpenSC should allow to sign data with length more than 512 bytes. #2300

Closed

Jakuje mentioned this pull request Sep 14, 2021

Fix typos found by codespell #2407

Merged

5 tasks

Add support for (X)EdDSA keys in OpenPGP driver #1960

Add support for (X)EdDSA keys in OpenPGP driver #1960

Uh oh!

Conversation

Jakuje commented Feb 25, 2020

Checklist

Uh oh!

Jakuje commented Feb 25, 2020

Uh oh!

lgtm-com bot commented Feb 26, 2020

Uh oh!

ueno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ueno left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alex-nitrokey commented Mar 24, 2020

Uh oh!

Jakuje commented Mar 24, 2020

Uh oh!

alex-nitrokey commented Mar 24, 2020

Uh oh!

Jakuje commented Mar 24, 2020

Uh oh!

alex-nitrokey commented Mar 24, 2020

Uh oh!

dengert commented Mar 24, 2020

Uh oh!

dengert commented Mar 24, 2020

Uh oh!

alex-nitrokey commented Mar 26, 2020

Uh oh!

alex-nitrokey commented Mar 26, 2020

Uh oh!

dengert commented Mar 26, 2020

Uh oh!

alex-nitrokey commented Mar 26, 2020

Uh oh!

Jakuje commented May 19, 2020

Uh oh!

frankmorgner commented May 20, 2020

Uh oh!

frankmorgner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented May 25, 2020

Uh oh!

Jakuje commented May 25, 2020

Uh oh!

Jakuje commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frankmorgner commented Mar 17, 2021

Uh oh!

popovec commented Mar 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Jakuje commented Mar 1, 2021 •

edited

Loading