opensc-notify: handle reader insertion/removal events #1923
Conversation
|
macOS is working now. Unfortunately, Windows has a high load after disconnecting a reader and I don't currently have the time to debug this... |
frankmorgner
force-pushed
the
pcsc-reader
branch
from
81600cc to
673d5d2
Compare
|
This pull request fixes 1 alert when merging 673d5d2 into d5ecafc - view on LGTM.com fixed alerts:
|
frankmorgner
force-pushed
the
pcsc-reader
branch
from
673d5d2 to
ed84e61
Compare
|
This pull request fixes 1 alert when merging ed84e61 into d5ecafc - view on LGTM.com fixed alerts:
|
frankmorgner
force-pushed
the
pcsc-reader
branch
from
ed84e61 to
584067a
Compare
|
This pull request fixes 1 alert when merging 584067a into 7840804 - view on LGTM.com fixed alerts:
|
frankmorgner
force-pushed
the
pcsc-reader
branch
from
584067a to
0803735
Compare
|
This pull request fixes 1 alert when merging 0803735 into 7840804 - view on LGTM.com fixed alerts:
|
frankmorgner
force-pushed
the
pcsc-reader
branch
from
e14374f to
d6c75e3
Compare
|
I finally had time to test this across all platforms. It turns out, that there are more differences than I have initially thought. It also seems that sc_wait_for_event hasn't been tested anywhere else than in PKCS#11... Anyway, it all now looks good! |
|
This pull request fixes 1 alert when merging d6c75e3 into 7840804 - view on LGTM.com fixed alerts:
|
- If readers are attatched, the new reader is probed for a card to check if a notification needs to be sent - removal of readers are not notified to the user, we assume that PC/SC sends the correct card removal event - The list of readers to be monitored is adjusted once a reader (dis)appears - On macOS, without PnP notification, we always check for new/removed readers with SCardListReaders - fixes interrupt handling in opensc-notify on Unix fixes OpenSC#1874
frankmorgner
force-pushed
the
pcsc-reader
branch
from
d6c75e3 to
2901a2d
Compare
|
This pull request fixes 1 alert when merging 2901a2d into 7840804 - view on LGTM.com fixed alerts:
|
1 participant
if a notification needs to be sent
sends the correct card removal event
readers with SCardListReaders
fixes #1874
Checklist