openpgp: ignore errors on SELECT DATA for OpenPGP 2 and below

frankmorgner · frankmorgner · commit b83c3586a238 · 2023-04-18T10:46:05.000+02:00
fixes #2752
diff --git a/src/libopensc/pkcs15-openpgp.c b/src/libopensc/pkcs15-openpgp.c
@@ -556,14 +556,9 @@ sc_pkcs15emu_openpgp_init(sc_pkcs15_card_t *p15card)
 		memset(&cert_info, 0, sizeof(cert_info));
 		memset(&cert_obj,  0, sizeof(cert_obj));
 
-		/* only try to SELECT DATA for OpenPGP >= v3 */
-		if (card->type >= SC_CARD_TYPE_OPENPGP_V3) {
-			r = sc_card_ctl(card, SC_CARDCTL_OPENPGP_SELECT_DATA, &i);
-			if (r < 0) {
-				free(buffer);
-				LOG_TEST_RET(card->ctx, r, "Failed OpenPGP - select data");
-			}
-		}
+		/* try to SELECT DATA. Will only work for OpenPGP >= v3, errors are non-critical */
+		sc_card_ctl(card, SC_CARDCTL_OPENPGP_SELECT_DATA, &i);
+
 		sc_format_path(certs[i].path, &cert_info.path);
 
 		/* Certificate ID. We use the same ID as the authentication key */
