scheduler/conf.c: Print to stderr if we don't open cups-files.conf#777
Merged
zdohnal merged 1 commit intoOpenPrinting:masterfrom Sep 4, 2023
Merged
scheduler/conf.c: Print to stderr if we don't open cups-files.conf#777zdohnal merged 1 commit intoOpenPrinting:masterfrom
zdohnal merged 1 commit intoOpenPrinting:masterfrom
Conversation
michaelrsweet
requested changes
Aug 29, 2023
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
If we are going to change this, we might as well include the error message (strerror).
zdohnal
force-pushed
the
readcupsfiles_stderr
branch
from
93e9991 to
4866876
Compare
Member
Author
|
Updated. |
michaelrsweet
requested changes
Aug 29, 2023
Member
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Minor tweak needed, then good to go.
scheduler/conf.c
Outdated
| #else | ||
| syslog(LOG_LPR, "Unable to open \"%s\" - %s", CupsFilesFile, strerror(errno)); | ||
| #endif /* HAVE_SYSTEMD_SD_JOURNAL_H */ | ||
| fprintf(stderr, "Unable to read \"%s\" - \"%s\".\n", CupsFilesFile, strerror(errno)); |
Member
There was a problem hiding this comment.
No need for quotes around the error message, nor the trailing period (since the error message usually has that). Otherwise OK.
In case cupsd can't open the cups-files.conf, the error message is lost if journal and syslog don't exist or work on system (usually in containers). Log the error into stderr at this place to get the error message if needed.
zdohnal
force-pushed
the
readcupsfiles_stderr
branch
from
1e6a89b to
db9cecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case cupsd can't open the cups-files.conf, the error message is lost if journal and syslog don't exist or work on system (usually in containers).
Log the error into stderr at this place to get the error message if needed.