Use "purge-job" instead of "purge-jobs" when canceling a single job#742
Use "purge-job" instead of "purge-jobs" when canceling a single job#742zdohnal merged 3 commits intoOpenPrinting:masterfrom
Conversation
The command "cancel -x <job>" adds "purge-jobs true" to the Cancel-Job operation; however, the correct attribute to use for Cancel-job is "purge-job" (singular), not "purge-jobs" (plural). As a result, job files are not removed from /var/spool/cups when "cancel -x <job>" is executed. This patch resolves the issue by adding "purge-job" when the IPP operation is Cancel-Job and "purge-jobs" for other IPP operations (Purge-Jobs, Cancel-Jobs, and Cancel-My-Jobs)
|
@michaelrsweet would you mind looking into it? Only reference I found about purge-jobs/purge-job is that Purge Jobs operation is deprecated http://ftp.pwg.org/pub/pwg/standards/std-ipp20-20151030-5100.12.pdf . Bryan sent me a link to old pwg email conversation https://www.pwg.org/archives/ipp/2009/016226.html which mentions the attributes, but it looks it is not mention in IPP 2.0+ standard. |
|
@zdohnal The "purge-job" attribute is a CUPS extension and has never been standardized. Given that it removes job history, the PWG is not interested in standardizing it (thus the deprecation of Purge-Jobs). |
michaelrsweet
left a comment
michaelrsweet
left a comment
There was a problem hiding this comment.
Just a minor coding style issue, otherwise LGTM.
3 participants
The command "cancel -x " adds "purge-jobs true" to the Cancel-Job operation; however, the correct attribute to use for Cancel-job is "purge-job" (singular), not "purge-jobs" (plural). As a result, job files are not removed from /var/spool/cups when "cancel -x " is executed.