add SYMBOLPREFIX and SYMBOLSUFFIX makefile options#459
Merged
xianyi merged 1 commit intoOpenMathLib:developfrom Oct 25, 2014
Merged
add SYMBOLPREFIX and SYMBOLSUFFIX makefile options#459xianyi merged 1 commit intoOpenMathLib:developfrom
xianyi merged 1 commit intoOpenMathLib:developfrom
Conversation
for adding a prefix or suffix to all exported symbol names in the shared library Useful to avoid conflicts with other BLAS libraries, especially when using 64 bit integer interfaces in OpenBLAS Note that since OSX does not have the objcopy utility, setting these options to non-empty values on Mac requires the objconv tool, available (GPL license) from http://www.agner.org/optimize/#objconv
xianyi
added a commit
that referenced
this pull request
Oct 25, 2014
add SYMBOLPREFIX and SYMBOLSUFFIX makefile options
Contributor
Author
|
Great, thanks @xianyi! Ping me if you end up needing to make any changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for adding a prefix or suffix to all exported symbol names in the shared library
Useful to avoid conflicts with other BLAS libraries, especially when using
64 bit integer interfaces in OpenBLAS
Note that since OSX does not have the objcopy utility, setting these options
to non-empty values on Mac requires the objconv tool, available (GPL license)
from http://www.agner.org/optimize/#objconv
(It is only run as a command-line application to change the symbol names at OpenBLAS-build-time so I don't think the GPL license is a problem, and if the options are not set then objconv is not needed.)
Refer to JuliaLang/julia#8734 and JuliaLang/julia#4923 for background motivation.