Merged
Conversation
j2rong4cn
force-pushed
the
add-disable-proxy-sign
branch
from
b61d3e0 to
46446c2
Compare
j2rong4cn
reviewed
Jul 20, 2025
Signed-off-by: j2rong4cn <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "disable proxy sign" feature that allows users to optionally disable signing for download proxy URLs. This provides more flexibility for proxy configurations where signing may not be necessary or desired.
- Centralizes proxy URL generation logic into a reusable function
- Adds a new boolean configuration option
disable_proxy_signto control signing behavior - Refactors WebDAV handling to use the new unified proxy URL generation approach
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/webdav/webdav.go | Refactors WebDAV proxy handling to use centralized URL generation and removes sign import |
| server/handles/fsread.go | Updates file reading handler to use new proxy URL generation function |
| server/handles/down.go | Simplifies download proxy logic using centralized URL generation and removes unused imports |
| server/common/proxy.go | Adds new GenerateDownProxyUrl function with configurable signing support |
| internal/op/driver.go | Adds disable_proxy_sign configuration option to driver items |
| internal/model/storage.go | Adds DisableProxySign field and renames WebdavProxy to WebdavProxyUrl for clarity |
Comments suppressed due to low confidence (2)
server/common/proxy.go:145
- [nitpick] Function name should follow Go naming conventions. Consider renaming to 'GenerateDownProxyURL' to properly capitalize the acronym 'URL'.
func GenerateDownProxyUrl(storage *model.Storage, reqPath string) string {
internal/model/storage.go:54
- [nitpick] Method name should follow Go naming conventions. Consider renaming to 'WebdavProxyURL' to properly capitalize the acronym 'URL'.
func (p Proxy) WebdavProxyUrl() bool {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.