fix(security): Directory traversal#744
Merged
j2rong4cn merged 3 commits intoOpenListTeam:mainfrom Jul 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical directory traversal security vulnerability in the file rename functionality. The vulnerability allowed users with upload and rename permissions to upload arbitrary files to arbitrary locations on local and SMB drives.
- Adds validation to prevent path separators in rename operations
- Prevents directory traversal attacks through filename manipulation
- Affects local and SMB drivers while cloud storage remains unaffected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拥有上传和重命名权限等于拥有上传任意文件到任意位置，受到影响驱动local,smb等，网盘不受影响。