feat(task-group): introduce TaskGroupCoordinator for coordinated task execution by sevxn007 · Pull Request #721 · OpenListTeam/OpenList

sevxn007 · 2025-07-15T03:41:32Z

添加任务hook函数
添加批量任务完成后操作
移动操作改用复制任务

close [BUG] 跨盘移动文件夹时，移动完成后，源文件夹没有删除 #552

refactor(move): move use CopyTask

Co-authored-by: Copilot <[email protected]> Signed-off-by: Seven <[email protected]>

internal/task/batch_task/batch_task.go

Copilot

Pull Request Overview

This PR introduces a task lifecycle interface, adds a batch-task coordinator for registering hooks that run after all related tasks complete, refactors existing tasks (Move, Copy, Transfer, Upload, Download, Archive) to use the new lifecycle, and standardizes MIME detection using utils.GetMimeType.

Added task.Lifecycle interface and RunWithLifecycle to manage BeforeRun, RunCore, and AfterRun hooks.
Implemented BatchTaskCoordinator in internal/task/batch_task and wired it into file and offline-download operations to perform refresh/remove logic after batches finish.
Replaced ad-hoc mime.TypeByExtension calls with utils.GetMimeType in WebDAV and HTTP serving code.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
server/webdav/prop.go	Replaced `mime.TypeByExtension` with `utils.GetMimeType`
server/handles/fsmanage.go	Updated `MoveWithTaskAndValidation` call to match new signature
internal/task/hook.go	Added `Lifecycle` interface and `RunWithLifecycle`
internal/task/batch_task/refresh.go	Created `refreshAndRemove` batch‐finish hook
internal/task/batch_task/batch_task.go	Introduced `BatchTaskCoordinator`
internal/offline_download/tool/transfer.go	Integrated batch hooks into transfer tasks
internal/offline_download/tool/download.go	Integrated batch hooks into download tasks
internal/offline_download/tool/add.go	Propagated `ApiUrl` and batch hooks into `AddURL` tasks
internal/net/serve.go	Switched HTTP serving to use `utils.GetMimeType`
internal/fs/put.go	Refactored upload tasks to lifecycle and added batch hooks
internal/fs/move.go	Refactored move tasks to lifecycle and integrated batch hooks
internal/fs/fs.go	Updated `MoveWithTaskAndValidation` signature
internal/fs/copy.go	Refactored copy tasks to lifecycle and added batch hooks
internal/fs/archive.go	Integrated batch hooks into archive download/upload tasks
internal/bootstrap/batch_task.go	Initialized batch‐task hook in bootstrap
cmd/server.go	Registered batch‐task hook on server startup

Comments suppressed due to low confidence (3)

internal/task/batch_task/batch_task.go:19

Typo in function name: NewBatchTasCoordinator should be spelled NewBatchTaskCoordinator for clarity and consistency.

func NewBatchTasCoordinator(name string) *BatchTaskCoordinator {

internal/task/batch_task/batch_task.go:33

Consider adding unit tests for BatchTaskCoordinator methods (AddTask, MarkTaskFinish, SetAllFinishHook) to verify that payloads are tracked correctly and hooks fire when counts reach zero.

func (bt *BatchTaskCoordinator) AddTask(targetPath string, payload any) {

server/handles/fsmanage.go:104

The original validateExistence flag (!req.Overwrite) was removed here, changing overwrite behavior. Reintroduce an explicit overwrite parameter or restore the previous call signature to preserve intended semantics.

		t, err := fs.MoveWithTaskAndValidation(c.Request.Context(), stdpath.Join(srcDir, name), dstDir, len(req.Names) > i+1)

j2rong4cn · 2025-07-22T12:22:22Z

没活了，就这样吧，再测试测试没bug的话就合了

sevxn007 · 2025-07-23T01:39:49Z

没活了，就这样吧，再测试测试没bug的话就合了

本地测试了下，没发现明显问题

PIKACHUIM · 2025-07-24T02:24:53Z

@Seven66677731 @j2rong4cn 辛苦看下冲突

… the directory that was copied or moved to." This reverts commit 5f03edd.

sevxn007 · 2025-07-24T07:39:37Z

@Seven66677731 @j2rong4cn 辛苦看下冲突

与#592 功能重复了，j2rong4cn 已经Revert，这个没啥问题了可以直接合并了

… execution (#721) * feat(task): add task hook,batch task refactor(move): move use CopyTask * Update internal/task/batch_task/refresh.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Seven <[email protected]> * fix: upload task allFinish judge * Update internal/task/batch_task/refresh.go Co-authored-by: Copilot <[email protected]> Signed-off-by: Seven <[email protected]> * feat: enhance concurrency safety * 优化代码 * 解压缩 * 修复死锁 * refactor(move): move as task * 重构，优化 * . * 优化，修复bug * . * 修复bug * feat: add task retry judge * 代理Task.SetState函数来判断Task的生命周期 * chore: use OnSucceeded、OnFailed、OnBeforeRetry functions * 优化 * 优化，去除重复代码 * . * 优化 * . * webdav * Revert "fix(fs):After the file is copied or moved, flush the cache of the directory that was copied or moved to." This reverts commit 5f03edd. --------- Signed-off-by: Seven <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: j2rong4cn <[email protected]>

feat(task): add task hook,batch task

6d4c938

refactor(move): move use CopyTask

SenkjM requested a review from Copilot July 15, 2025 03:46

This comment was marked as outdated.

Sign in to view

sevxn007 and others added 3 commits July 15, 2025 11:54

Update internal/task/batch_task/refresh.go

16ed788

Co-authored-by: Copilot <[email protected]> Signed-off-by: Seven <[email protected]>

fix: upload task allFinish judge

ae92148

Update internal/task/batch_task/refresh.go

bbc82a8

Co-authored-by: Copilot <[email protected]> Signed-off-by: Seven <[email protected]>

dezhishen requested changes Jul 15, 2025

View reviewed changes

internal/task/batch_task/batch_task.go Outdated Show resolved Hide resolved

sevxn007 and others added 5 commits July 15, 2025 14:04

feat: enhance concurrency safety

4155767

优化代码

02565a0

解压缩

5040c2c

修复死锁

d85e12e

refactor(move): move as task

565b540

sevxn007 changed the title ~~feat(task): add task hook,batch task refactor(move): move use CopyTask~~ feat(task): add task hook,batch task Jul 15, 2025

j2rong4cn marked this pull request as draft July 15, 2025 09:25

j2rong4cn force-pushed the feat/task branch from 53bfcbb to ff4ef25 Compare July 15, 2025 10:41

j2rong4cn marked this pull request as ready for review July 15, 2025 10:42

j2rong4cn marked this pull request as draft July 15, 2025 12:06

重构，优化

022decb

j2rong4cn force-pushed the feat/task branch from ff4ef25 to 022decb Compare July 15, 2025 12:50

.

224c38f

j2rong4cn assigned j2rong4cn and unassigned j2rong4cn Jul 15, 2025

j2rong4cn added 2 commits July 16, 2025 02:07

优化，修复bug

3ecfe6c

.

3399cd9

j2rong4cn force-pushed the feat/task branch from 646b1d8 to 3399cd9 Compare July 15, 2025 18:47

修复bug

2be3d8b

jyxjjj requested a review from Copilot July 16, 2025 12:26

Copilot AI reviewed Jul 16, 2025

View reviewed changes

feat: add task retry judge

5c3741f

sevxn007 marked this pull request as ready for review July 17, 2025 01:49

j2rong4cn marked this pull request as draft July 17, 2025 05:54

j2rong4cn and others added 3 commits July 17, 2025 16:35

代理Task.SetState函数来判断Task的生命周期

f0b4276

chore: use OnSucceeded、OnFailed、OnBeforeRetry functions

723045e

优化

f784784

j2rong4cn marked this pull request as ready for review July 19, 2025 07:30

j2rong4cn marked this pull request as draft July 19, 2025 07:31

优化，去除重复代码

28dc3c0

j2rong4cn force-pushed the feat/task branch from 1320a6b to 28dc3c0 Compare July 19, 2025 07:43

j2rong4cn marked this pull request as ready for review July 19, 2025 07:50

Merge remote-tracking branch 'origin/main' into feat/task

9601140

j2rong4cn force-pushed the feat/task branch from d024622 to 9601140 Compare July 19, 2025 12:53

j2rong4cn changed the title ~~feat(task): add task hook,batch task~~ feat(task-group): introduce TaskGroupCoordinator for coordinated task execution Jul 19, 2025

j2rong4cn added 3 commits July 19, 2025 21:09

.

52f75ee

优化

9d8470f

Merge remote-tracking branch 'origin/main' into feat/task

e9bf00e

j2rong4cn force-pushed the feat/task branch from fe53e01 to e9bf00e Compare July 20, 2025 15:50

sevxn007 and others added 3 commits July 21, 2025 16:19

Merge branch 'OpenListTeam:main' into feat/task

1ce512c

.

330fae5

webdav

2de3339

j2rong4cn added 2 commits July 24, 2025 12:23

Revert "fix(fs):After the file is copied or moved, flush the cache of…

85c2b9c

… the directory that was copied or moved to." This reverts commit 5f03edd.

Merge branch 'main' into feat/task

a4f3a52

PIKACHUIM merged commit e93ab76 into OpenListTeam:main Jul 24, 2025
12 checks passed

xrgzs mentioned this pull request Jul 24, 2025

[BUG] WebDAV 跨驱动复制报错 500 #822

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(task-group): introduce TaskGroupCoordinator for coordinated task execution#721

feat(task-group): introduce TaskGroupCoordinator for coordinated task execution#721
PIKACHUIM merged 28 commits intoOpenListTeam:mainfrom
sevxn007:feat/task

sevxn007 commented Jul 15, 2025 •

edited by j2rong4cn

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

j2rong4cn commented Jul 22, 2025

Uh oh!

sevxn007 commented Jul 23, 2025

Uh oh!

PIKACHUIM commented Jul 24, 2025

Uh oh!

sevxn007 commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

sevxn007 commented Jul 15, 2025 • edited by j2rong4cn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

j2rong4cn commented Jul 22, 2025

Uh oh!

sevxn007 commented Jul 23, 2025

Uh oh!

PIKACHUIM commented Jul 24, 2025

Uh oh!

sevxn007 commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sevxn007 commented Jul 15, 2025 •

edited by j2rong4cn

Loading