Skip to content

Python: fix .with_additional_properties() annotation #4197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kacpermuda merged 1 commit into from
Dec 12, 2025
Merged

Python: fix .with_additional_properties() annotation #4197

kacpermuda merged 1 commit into from
Dec 12, 2025

Conversation

@dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Dec 12, 2025 •
edited
Loading

One-line summary for changelog:

Python: fix .with_additional_properties() annotation

Meaningful description

Currently this code fails on mypy:

from openlineage.client.generated.base import BaseFacet

facet = BaseFacet().with_additional_properties(a="b")
123.py:3: error: Argument "a" to "with_additional_properties" of "BaseFacet" has incompatible type "str"; expected "dict[str, Any]"  [arg-type]
    facet = BaseFacet().with_additional_properties(a="b")
                                                     ^~~
Found 1 error in 1 file (checked 1 source file)

This is because def func(**kwargs: dict[str, Any]) expect every item of kwargs map to be a dict[str, Any].

@dolfinus dolfinus requested a review from a team as a code owner December 12, 2025 08:51
@boring-cyborg boring-cyborg bot added area:client/python openlineage-python language:python Uses Python programming language labels Dec 12, 2025
@dolfinus dolfinus force-pushed the bugfix/python-additional-properties-typing branch from 32cce69 to c63b22f Compare December 12, 2025 08:52
@dolfinus
Copy link
Contributor Author

dolfinus commented Dec 12, 2025

Failed unit-test-integration-common is unrelated

@kacpermuda
Copy link
Contributor

kacpermuda commented Dec 12, 2025

Failing SQL parser test is unrelated.

@kacpermuda kacpermuda merged commit 5b272d5 into OpenLineage:main Dec 12, 2025
16 of 17 checks passed
@dolfinus dolfinus deleted the bugfix/python-additional-properties-typing branch December 12, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:client/python openlineage-python language:python Uses Python programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dolfinus @kacpermuda