Bugfix in ConnectorServer.bat#44
Merged
Merged
Conversation
…srvRun section of the ConnectorServer.bat file. This space is necessary to separate Java parameters when starting server with the /run key. If there is no separator, the parameters are concatenated into one line without spaces and simply do not work. I encountered this bug when I tried to set up a secure connection to the OpenICF connector server via SSL. Example from usage: «ConnectorServer.bat /run "-J-Djavax.net.ssl.keyStore=keystore.jks" "-J-Djavax.net.ssl.keyStorePassword=changeit"» does not work for this reason. I found the error very confusing, because in normal mode the connector server does not output any errors to the console related to this bug.
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a space character « » to the JAVA_OPTS_DELIM parameter of the :srvRun section of the ConnectorServer.bat file.
This space is necessary to separate Java parameters when starting server with the /run key.
If there is no separator, the parameters are concatenated into one line without spaces and simply do not work.
I encountered this bug when I tried to set up a secure connection to the OpenICF connector server via SSL. Example from usage: «ConnectorServer.bat /run "-J-Djavax.net.ssl.keyStore=keystore.jks" "-J-Djavax.net.ssl.keyStorePassword=changeit"» does not work for this reason.
I found the error very confusing, because in normal mode the connector server does not output any errors to the console related to this bug.