Skip to content

fix(enterprise): log automation HTTP response failures as errors - #15004

Merged
aivong-openhands merged 2 commits into
OpenHands:mainfrom
wgu9:fix-automation-http-error-log-level
Jun 29, 2026
Merged

aivong-openhands merged 2 commits into
OpenHands:mainfrom
wgu9:fix-automation-http-error-log-level

Conversation

@wgu9

@wgu9 wgu9 commented Jun 26, 2026 •

Copy link
Copy Markdown
Contributor

HUMAN: This PR changes automation service HTTP 4xx event-forwarding failures to log at error level, matching the existing 5xx/timeout/client-error failure path. I have not manually exercised the hosted automation service path.

  • A human has tested these changes.

Summary

  • log automation service HTTP 4xx responses at error level, matching 5xx/timeout/client-error delivery failures
  • keep the forwarding behavior unchanged while making the log severity reflect that the event was not delivered
  • update the existing 4xx regression test to assert logger.error and no warning

Duplicate check

Tests

  • commit hook backend pre-commit passed during commit, including debug statement check, AppMode check, pyproject checks, ruff hooks with no matching staged files, and mypy
  • python -m compileall enterprise/server/services/automation_event_service.py enterprise/tests/unit/server/services/test_automation_event_service.py
  • git diff --check

Attempted but could not complete locally:

  • PYTHONPATH=enterprise:. python -m pytest enterprise/tests/unit/server/services/test_automation_event_service.py::TestSendToAutomationService::test_send_4xx_logs_error ... -q
  • blocked by incomplete local project dependencies after the earlier make install-pre-commit-hooks setup failed on macOS Xcode SDK / chroma-hnswlib; after installing PyJWT/python-keycloak/termcolor, pytest still stopped at ModuleNotFoundError: No module named 'openhands.sdk'.

Fixes #14859

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for opening this PR!

Before review, please add a short note in the HUMAN: section at the top of the PR description telling maintainers, in your own words, what this PR does.

Please put that note between HUMAN: and the - [ ] A human has tested these changes. checkbox.

@github-actions github-actions Bot added the type: fix A bug fix label Jun 26, 2026
@aivong-openhands
aivong-openhands merged commit 0258cee into OpenHands:main Jun 29, 2026
17 checks passed
@openhands-release-bot openhands-release-bot Bot added the released: 1.9.0 Shipped in 1.9.0 label Jul 6, 2026
@openhands-release-bot

Copy link
Copy Markdown
Contributor

🚀 Released in 1.9.0.

@openhands-release-bot

Copy link
Copy Markdown
Contributor

🚀 Released in cloud-1.41.0.

@openhands-release-bot openhands-release-bot Bot added the released: cloud-1.41.0 Shipped in cloud-1.41.0 label Jul 6, 2026
@wgu9
wgu9 deleted the fix-automation-http-error-log-level branch July 6, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released: cloud-1.41.0 Shipped in cloud-1.41.0 released: 1.9.0 Shipped in 1.9.0 type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: log level warning → error for HTTP 4xx/5xx responses in automation service event forwarding

2 participants