Repository navigation
fix(enterprise): log automation HTTP response failures as errors - #15004
Merged
aivong-openhands merged 2 commits intoJun 29, 2026
Merged
Conversation
Contributor
|
👋 Thanks for opening this PR! Before review, please add a short note in the Please put that note between |
aivong-openhands
approved these changes
Jun 29, 2026
This was referenced Jun 29, 2026
Contributor
|
🚀 Released in 1.9.0. |
Contributor
|
🚀 Released in cloud-1.41.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN: This PR changes automation service HTTP 4xx event-forwarding failures to log at error level, matching the existing 5xx/timeout/client-error failure path. I have not manually exercised the hosted automation service path.
Summary
logger.errorand no warningDuplicate check
Tests
python -m compileall enterprise/server/services/automation_event_service.py enterprise/tests/unit/server/services/test_automation_event_service.pygit diff --checkAttempted but could not complete locally:
PYTHONPATH=enterprise:. python -m pytest enterprise/tests/unit/server/services/test_automation_event_service.py::TestSendToAutomationService::test_send_4xx_logs_error ... -qmake install-pre-commit-hookssetup failed on macOS Xcode SDK /chroma-hnswlib; after installing PyJWT/python-keycloak/termcolor, pytest still stopped atModuleNotFoundError: No module named 'openhands.sdk'.Fixes #14859