Skip to content

Integrating KEDA http-addon #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminhuo merged 18 commits into from
Sep 7, 2023
Merged

Integrating KEDA http-addon #483

benjaminhuo merged 18 commits into from
Sep 7, 2023

Conversation

@B1F030
Copy link
Contributor

@B1F030 B1F030 commented Aug 18, 2023

No description provided.

@benjaminhuo
Copy link
Member

benjaminhuo commented Aug 19, 2023

image
@B1F030 You'll need to run make manifests

@B1F030
make generate synced
6b9c8c7 
Signed-off-by: B1F030 <[email protected]>
@B1F030
Copy link
Contributor Author

B1F030 commented Aug 19, 2023 •
edited
Loading

image @B1F030 You'll need to run make manifests

I have synced the code with my cluster now, and make verify successfully.
There may be some problems yet, and I will keep updating this PR.

@B1F030 B1F030 closed this Aug 19, 2023
@B1F030 B1F030 reopened this Aug 19, 2023
tpiperatgod
tpiperatgod reviewed Aug 20, 2023
View reviewed changes
tpiperatgod
tpiperatgod reviewed Aug 20, 2023
View reviewed changes
tpiperatgod
tpiperatgod reviewed Aug 20, 2023
View reviewed changes
tpiperatgod
tpiperatgod reviewed Aug 20, 2023
View reviewed changes
wanjunlei
wanjunlei reviewed Aug 21, 2023
View reviewed changes
B1F030 added 12 commits August 21, 2023 17:54
@B1F030
change HttpRuntime const to HttpEngine
cd9d324 
Signed-off-by: B1F030 <[email protected]>
@B1F030
optimize the judgment logic in serving_controller.go
a2076b7 
Signed-off-by: B1F030 <[email protected]>
@B1F030
use goimports to sort the import
8c43f0d 
Signed-off-by: B1F030 <[email protected]>
@B1F030
optimized some judgment logic codes in apis/core/v1beta2/function_web…
25431c2 
…hook.go

Signed-off-by: B1F030 <[email protected]>
@B1F030
correct the judgment logic code
af32d3f 
Signed-off-by: B1F030 <[email protected]>
@B1F030
SetControllerReference for generated service
ef607a8 
Signed-off-by: B1F030 <[email protected]>
@B1F030
add some comments and a const called ingressName
3d5f553 
Signed-off-by: B1F030 <[email protected]>
@B1F030
remove service with async function
5cccc68 
Signed-off-by: B1F030 <[email protected]>
@B1F030
update proposal to latest version
10c50cc 
Signed-off-by: B1F030 <[email protected]>
@B1F030
KEDA http-addon reconcilation finished
ab78f26 
Signed-off-by: B1F030 <[email protected]>
@B1F030
complete function_webhook_test validate code for scaleOptions.keda
5fdbeda 
Signed-off-by: B1F030 <[email protected]>
@B1F030
add validation for keda.httpScaledObject.cooldownPeriod
bea4e2d 
Signed-off-by: B1F030 <[email protected]>
@B1F030 B1F030 mentioned this pull request Sep 7, 2023
Closed
benjaminhuo
benjaminhuo requested changes Sep 7, 2023
View reviewed changes
@benjaminhuo
Copy link
Member

benjaminhuo commented Sep 7, 2023

@B1F030 Thanks for this PR, it's great to have keda-http as another HTTP engine finally. Just some minor issues need to be resolved.

@benjaminhuo benjaminhuo merged commit 92fe37b into OpenFunction:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpiperatgod tpiperatgod tpiperatgod left review comments

@wanjunlei wanjunlei wanjunlei left review comments

@benjaminhuo benjaminhuo benjaminhuo approved these changes

@wrongerror wrongerror Awaiting requested review from wrongerror

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@B1F030 @benjaminhuo @tpiperatgod @wanjunlei