Skip to content

Delegate Optional record field handling to Jackson#3274

Merged
velo merged 1 commit intomasterfrom
fix/graphql-decoder-delegate-optional-to-jackson
Mar 17, 2026
Merged

Delegate Optional record field handling to Jackson#3274
velo merged 1 commit intomasterfrom
fix/graphql-decoder-delegate-optional-to-jackson

Conversation

@velo
Copy link
Copy Markdown
Member

@velo velo commented Mar 17, 2026

Summary

  • Remove custom convertWithOptionalSupport() reflection-based method (~50 lines) from GraphqlDecoder
  • Delegate Optional field deserialization in records to Jackson via jackson-datatype-jdk8 module
  • Add jackson-datatype-jdk8 test dependency and document the Jackson configuration requirement in README

Test plan

  • All 45 graphql module tests pass (mvn test -pl graphql)
  • Verified all remaining imports are actively used
  • README documents the findAndRegisterModules() requirement for users

🤖 Generated with Claude Code

@velo velo merged commit 171f9c3 into master Mar 17, 2026
4 checks passed
@velo velo deleted the fix/graphql-decoder-delegate-optional-to-jackson branch March 17, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant