Fix GraphqlDecoder Optional record fields and non-nullable list nulls#3272
Merged
Fix GraphqlDecoder Optional record fields and non-nullable list nulls#3272
Conversation
…ll, non-nullable lists never return null Signed-off-by: Marvin Froeder <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphqlDecodernow properly returnsOptional.empty()instead ofnullfor Optional-typed record fields. The decoder manually constructs records with Optional fields to avoid Jackson'sconvertValuelimitation, recursively handling N-level deep nested records.null— the decoder returns empty collections for null body, null operation data, and any other null-producing code path.Test plan
decodesRecordWithOptionalFieldPresentdecodesRecordWithOptionalFieldNull— verifiesOptional.empty()notnulldecodesRecordWithOptionalFieldMissing— verifiesOptional.empty()notnulldecodesNestedRecordWithOptionalFields— 2-level deepdecodesDeeplyNestedRecordWithOptionalFields— 3-level deepreturnsEmptyListForNullBodyreturnsEmptyListForNullOperationDataWithListType🤖 Generated with Claude Code